Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: GIGABYTE.GigabyteControlCenter version 25.02.07.01 #230284

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

New version: GIGABYTE.GigabyteControlCenter version 25.02.07.01 #230284

wants to merge 4 commits into from
+84 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Feb 16, 2025 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

Image

Microsoft Reviewers: Open in CodeFlow

@Dragon1573
New version: GIGABYTE.GigabyteControlCenter version 25.02.07.01
e3de9a0 
Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

Url Validation Error

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Feb 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 16, 2025
@DuckDuckStudio

This comment was marked as resolved.

Sign in to view
@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
f000099 
- Remove Mainland China specific installer entrance
  - The unified ".com" domain is not blocked in China
  - In Mainland China, ".com" will be automatically redirected to ".cn"
  - ".cn" connection speed is slightly slower than ".com"

Co-authored-by: 鸭鸭「カモ」 <89643991+DuckDuckStudio@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application labels Feb 17, 2025
@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
12939fa 
- Correction of "DisplayVersion" property to match that in screenshot

Co-authored-by: 鸭鸭「カモ」 <89643991+DuckDuckStudio@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

Url Validation Error

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Feb 17, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 17, 2025
@Dragon1573
Copy link
Contributor Author

Hello @Dragon1573,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

This problem should be suppressed.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Feb 17, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335229 2025-02-17 01:08:06.394 [CLI ] Caught std::exception: bad allocation

Automated error analysis suggests -1978335229 may mean Executing command failed

(Automated response - build 980.)

@stephengillie
Copy link
Collaborator

Hello @Dragon1573,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.
Template: msftbot/validationError/installation/general

This problem should be suppressed.

@microsoft-github-policy-service microsoft-github-policy-service bot added Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. labels Feb 17, 2025
@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
a7ecb58 
- Switch domain suffix of the package
- Prevent false positive report of region blocking

Co-authored-by: 鸭鸭「カモ」 <89643991+DuckDuckStudio@users.noreply.github.com>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application Changes-Requested Changes Requested labels Feb 18, 2025
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Feb 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 18, 2025
@Dragon1573 Dragon1573 removed their assignment Feb 18, 2025
@DuckDuckStudio

This comment was marked as resolved.

Sign in to view
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335229 2025-02-17 22:54:37.115 [CLI ] Caught std::exception: bad allocation

Automated error analysis suggests -1978335229 may mean Executing command failed

(Automated response - build 981.)

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Installation-Error Error installing application Needs-Author-Feedback This needs a response from the author. labels Feb 22, 2025
@stephengillie
Copy link
Collaborator

Hi @Dragon1573,

Manual Validation ended with an error message. Verify:
image
This app is tray-based:
image
The main application doesn't display any UI elements.
image
But clicking the question mark in a circle on the top bar showed the tutorial, so it's responsive, just without UI:
image

Is this expected?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Feb 23, 2025
DuckDuckStudio

This comment was marked as duplicate.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuckDuckStudio DuckDuckStudio DuckDuckStudio left review comments

@stephengillie stephengillie stephengillie requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: GIGABYTE.GigabyteControlCenter version 25.02.07.01
4 participants
@Dragon1573 @wingetbot @DuckDuckStudio @stephengillie