Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CAM16 based color scheme "Dimidium" #18563

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

dofuuz
Copy link
Contributor

@dofuuz dofuuz commented Feb 12, 2025

Okay, here is a challenge for the default color scheme.

Summary of the Pull Request

This PR adds Dimidium terminal color scheme.

palette

References and Relevant Issues

#17818
#18502

Detailed Description of the Pull Request / Additional comments

I adjusted colors using CAM16. I prioritized lightness so that all colors(especially blue) has appropriate contrast with the background.

Brief information about the Dimidium color scheme

Detailed explanation on crafting the color scheme with CAM16

hue-chroma

dimidium

preview-terminal
🔍 More preview

This comment has been minimized.

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

@DHowett
Copy link
Member

DHowett commented Feb 20, 2025

Thanks for the patience! Sorry we took a while to get back to you - we've been doing a lot of post-release-engineering engineering.

I'm tapping in @lhecker to be the final reviewer here. 🙂

Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I wouldn't use it because the reds are a little orange and purple respectively. Same for other colors.

But I think that it follows a great idea that people may like, so I think we should try it.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Second It's a PR that needs another sign-off label Feb 20, 2025
@DHowett
Copy link
Member

DHowett commented Feb 20, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DHowett DHowett merged commit b6b8cab into microsoft:main Feb 20, 2025
14 checks passed
@dofuuz
Copy link
Contributor Author

dofuuz commented Feb 22, 2025

Nice! 😄

A slight tint on each color is intentional. I added a slight hue shift between normal and bright colors to make them more distinct.

For now, selection is white, and cursor is bright green (like PuTTY). Let me know if you want to change them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants