Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Input and output are not collected with Fast API engine in AML #3929

Open
prise6 opened this issue Jan 20, 2025 · 2 comments
Open

[BUG] Input and output are not collected with Fast API engine in AML #3929

prise6 opened this issue Jan 20, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@prise6
Copy link

prise6 commented Jan 20, 2025

Describe the bug
Promptflow server runtime with FastAPI doesn't write intput/output in collector.

How To Reproduce the bug
With v2 fastapi + managed online endpoint with Azure Machine Learning (AML), the data collector can't write anything because in FlowMonitor input_data are requested with input_data = self.context_data_provider.get_request_data(). This method looks for a key called input_data in FastapiContextDataProvider.
But the value of this key is None because we don't set it correctly in get_score_router()

code source: src/promptflow-core/promptflow/core/_serving/v2/routers/score.py

Expected behavior
Same behavior than Flask engine.

Additional context
I wrote a PR #3890

@prise6 prise6 added the bug Something isn't working label Jan 20, 2025
Copy link

Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Feb 19, 2025
@prise6
Copy link
Author

prise6 commented Feb 20, 2025

Still an issue... and it's sad you don't fix it.

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant