Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CPUID handling in kernel #816

Open
vibhutet opened this issue Feb 7, 2025 · 2 comments
Open

Update the CPUID handling in kernel #816

vibhutet opened this issue Feb 7, 2025 · 2 comments
Assignees
Labels
ohcl-linux-kernel Changes that apply to the Linux kernel at OHCL-Linux-Kernel repo tdx TDX specific bugs or features

Comments

@vibhutet
Copy link
Contributor

vibhutet commented Feb 7, 2025

The kernel forwards most CPUID intercepts received in #VE handler to the user mode without any particular handling. Ex. For CPUID leaf 0xB the user mode receives all 0s. This CPUID is used to identify the topology of the CVM. Receiving all 0s leads to incorrect building and identification of topology.
Fix the CPUID intercept in the kernel. Once that is fixed, on the user mode review the validation of leaf 0xB in extended_topology()

@smalis-msft smalis-msft added the tdx TDX specific bugs or features label Feb 7, 2025
@stephensons2022 stephensons2022 self-assigned this Feb 18, 2025
@chris-oo
Copy link
Member

What exactly is the issue here - that we cannot get the right information we need in usermode via cpuid because the kernel is not filling out the right info in the #VE handler? Does the kernel even know that info or do we need to also update the kernel to query the correct TDX module, or what is the ultimate source of this information?

@vibhutet
Copy link
Contributor Author

The kernel needs to query the TDX module to get the right information and pass it to the user mode.

@chris-oo chris-oo added the ohcl-linux-kernel Changes that apply to the Linux kernel at OHCL-Linux-Kernel repo label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ohcl-linux-kernel Changes that apply to the Linux kernel at OHCL-Linux-Kernel repo tdx TDX specific bugs or features
Projects
None yet
Development

No branches or pull requests

4 participants