Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fdt/builder: enforce BE datatypes on add_prop_array #777

Open
chris-oo opened this issue Feb 4, 2025 · 0 comments
Open

fdt/builder: enforce BE datatypes on add_prop_array #777

chris-oo opened this issue Feb 4, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@chris-oo
Copy link
Member

chris-oo commented Feb 4, 2025

add_prop_array doesn't have any checks that the data is Big Endian. FDT requires that data is BE. Current usage kind of gets away with it, as we pass empty ranges or just u8 unformed entropy data.

Perhaps we should use zerocopy BE byte types for add_prop_array and also perhaps prop_array_iter?
@chris-oo chris-oo added enhancement New feature or request good first issue Good for newcomers labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chris-oo