Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executor stdout and stderr should be in their own files #793

Closed
MattMcL4475 opened this issue Sep 28, 2024 · 1 comment · Fixed by #800
Closed

Executor stdout and stderr should be in their own files #793

MattMcL4475 opened this issue Sep 28, 2024 · 1 comment · Fixed by #800
Assignees
Labels
enhancement New feature or request TES Priority: P2 Groomed to a Priority 2 issue

Comments

@MattMcL4475
Copy link
Collaborator

MattMcL4475 commented Sep 28, 2024

Use the following naming schema:

task-executor-stdout-1.txt
task-executor-stderr-1.txt
task-executor-stdout-2.txt
task-executor-stderr-2.txt

Currently, the exec_stdout intersperses TES Runner CLI logs with the tool logs themselves. It seems the executors stdout and stderr should be in clean files by themselves. As part of this issue, it seems we should rethink the file names too. It's confusing that stdout.txt is actually the TES runner stdout.txt, and the executor itself doesn't have it's own file.

2024-09-28 20:02:32.741 info: Tes.Runner.Authentication.CredentialsManager[0]
2024-09-28 20:02:35.651 info: Tes.Runner.Events.EventsPublisher[0]
Publishing event executorStart to sink: BlobStorageEventSink
2024-09-28 20:02:35.717 info: Tes.Runner.Docker.DockerExecutor[0]
Pulling image name: ubuntu image tag: 22.04
2024-09-28 20:02:37.130 info: Tes.Runner.Docker.DockerExecutor[0]
Creating container with image name: ubuntu:22.04
Get:1 http://security.ubuntu.com/ubuntu jammy-security InRelease [129 kB]
Get:2 http://archive.ubuntu.com/ubuntu jammy InRelease [270 kB]
Get:3 http://archive.ubuntu.com/ubuntu jammy-updates InRelease [128 kB]
Get:4 http://archive.ubuntu.com/ubuntu jammy-backports InRelease [127 kB]
Get:5 http://security.ubuntu.com/ubuntu jammy-security/universe amd64 Packages [1156 kB]
Get:6 http://archive.ubuntu.com/ubuntu jammy/main amd64 Packages [1792 kB]
Get:7 http://security.ubuntu.com/ubuntu jammy-security/multiverse amd64 Packages [44.7 kB]
Get:8 http://security.ubuntu.com/ubuntu jammy-security/restricted amd64 Packages [3113 kB]
Get:9 http://archive.ubuntu.com/ubuntu jammy/restricted amd64 Packages [164 kB]
Get:10 http://archive.ubuntu.com/ubuntu jammy/universe amd64 Packages [17.5 MB]
Get:11 http://security.ubuntu.com/ubuntu jammy-security/main amd64 Packages [2318 kB]
Get:12 http://archive.ubuntu.com/ubuntu jammy/multiverse amd64 Packages [266 kB]
Get:13 http://archive.ubuntu.com/ubuntu jammy-updates/universe amd64 Packages [1445 kB]
Get:14 http://archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages [2595 kB]
Get:15 http://archive.ubuntu.com/ubuntu jammy-updates/multiverse amd64 Packages [51.8 kB]
Get:16 http://archive.ubuntu.com/ubuntu jammy-updates/restricted amd64 Packages [3191 kB]
Get:17 http://archive.ubuntu.com/ubuntu jammy-backports/universe amd64 Packages [33.7 kB]
Get:18 http://archive.ubuntu.com/ubuntu jammy-backports/main amd64 Packages [81.4 kB]
Fetched 34.4 MB in 13s (2743 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
libprimesieve9 primesieve-bin
Suggested packages:
primesieve-doc
The following NEW packages will be installed:
libprimesieve9 primesieve primesieve-bin
0 upgraded, 3 newly installed, 0 to remove and 0 not upgraded.
Need to get 109 kB of archives.
After this operation, 323 kB of additional disk space will be used.
Get:1 http://archive.ubuntu.com/ubuntu jammy/universe amd64 libprimesieve9 amd64 7.8+ds-1 [76.7 kB]
Get:2 http://archive.ubuntu.com/ubuntu jammy/universe amd64 primesieve-bin amd64 7.8+ds-1 [28.6 kB]
Get:3 http://archive.ubuntu.com/ubuntu jammy/universe amd64 primesieve all 7.8+ds-1 [3212 B]
Fetched 109 kB in 2s (54.7 kB/s)
Selecting previously unselected package libprimesieve9:amd64.
(Reading database ...
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 4393 files and directories currently installed.)
Preparing to unpack .../libprimesieve9_7.8+ds-1_amd64.deb ...
Unpacking libprimesieve9:amd64 (7.8+ds-1) ...
Selecting previously unselected package primesieve-bin.
Preparing to unpack .../primesieve-bin_7.8+ds-1_amd64.deb ...
Unpacking primesieve-bin (7.8+ds-1) ...
Selecting previously unselected package primesieve.
Preparing to unpack .../primesieve_7.8+ds-1_all.deb ...
Unpacking primesieve (7.8+ds-1) ...
Setting up libprimesieve9:amd64 (7.8+ds-1) ...
Setting up primesieve-bin (7.8+ds-1) ...
Setting up primesieve (7.8+ds-1) ...
Processing triggers for libc-bin (2.35-0ubuntu3.8) ...
2024-09-28 20:03:15.183 info: Tes.Runner.Events.EventsPublisher[0]
Publishing event executorEnd to sink: BlobStorageEventSink
2024-09-28 20:03:15.201 info: Tes.RunnerCLI.Commands.CommandHandlers[0]
Docker container execution status code: 0

@MattMcL4475 MattMcL4475 added the enhancement New feature or request label Sep 28, 2024
@MattMcL4475 MattMcL4475 changed the title Executor log should be in its own file Executor stdout and stderr should be in their own files Sep 28, 2024
@MattMcL4475 MattMcL4475 changed the title Executor stdout and stderr should be in their own files Executor stdout and stderr should be in their own files - also name confusion Sep 28, 2024
@MattMcL4475 MattMcL4475 changed the title Executor stdout and stderr should be in their own files - also name confusion Executor stdout and stderr should be in their own files Sep 28, 2024
@MattMcL4475
Copy link
Collaborator Author

#427

@MattMcL4475 MattMcL4475 added TES Priority: P1 Groomed to a Priority 1 issue TES Priority: P2 Groomed to a Priority 2 issue and removed TES Priority: P1 Groomed to a Priority 1 issue labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TES Priority: P2 Groomed to a Priority 2 issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants