Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete colors pass 5 #3339

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Conversation

rurikoaraki
Copy link
Collaborator

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Remove unused colors. Checked some clients for usage.
This is the final pass of color removal. All other colors are used by either our own controls or by clients.

@rurikoaraki rurikoaraki requested a review from a team as a code owner January 4, 2024 01:33
@Saadnajmi
Copy link
Collaborator

"All other colors are used by either our own controls or by clients."
I assume this includes the legacy components too. If there are a few that can be refactored to use new colors, would that be virtuous? Or would that maybe cause issues with people using .customize()?

@rurikoaraki
Copy link
Collaborator Author

"All other colors are used by either our own controls or by clients." I assume this includes the legacy components too. If there are a few that can be refactored to use new colors, would that be virtuous? Or would that maybe cause issues with people using .customize()?

Most usages in clients are to fill in theme colors or assigning colors directly, so I think customize should be ok, but I don't think the work to move old components to use new colors would be trivial. I think it would be better to get clients to move to new components, since we want that to happen anyway.

@rurikoaraki rurikoaraki merged commit da4796b into microsoft:main Jan 4, 2024
11 checks passed
@rurikoaraki rurikoaraki deleted the delete_colors_pass5 branch January 4, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants