Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXOMailTips: All properties already exist in EXOOrganizationConfig #5647

Open
ricmestre opened this issue Jan 18, 2025 · 5 comments · May be fixed by #5773
Open

EXOMailTips: All properties already exist in EXOOrganizationConfig #5647

ricmestre opened this issue Jan 18, 2025 · 5 comments · May be fixed by #5773
Labels
Enhancement New feature or request Exchange Online

Comments

@ricmestre
Copy link
Contributor

Description of the issue

All the properties found in EXOMailTips are already retrieved/set through EXOOrganizationConfig resource.

Microsoft 365 DSC Version

1.25.115.1

Which workloads are affected

Exchange Online

The DSC configuration

N/A

Verbose logs showing the problem

N/A

Environment Information + PowerShell Version

Win11/PS5.1
@ykuijs
Copy link
Member

ykuijs commented Jan 21, 2025

Interesting that this isn't discovered earlier 😉

We should consolidate this to just one resource. Any suggestion which one?

@ykuijs ykuijs added Enhancement New feature or request Exchange Online labels Jan 21, 2025
@FabienTschanz
Copy link
Collaborator

I'd prefer the EXOOrganizationConfig since it contains everything of EXOMailTips as well as many other properties. It's also using Get-OrganizationConfig, so they both have the same source.

@ricmestre
Copy link
Contributor Author

ricmestre commented Jan 21, 2025 •
edited
Loading

Yep, I also prefer having only EXOOrganizationConfig since EXOMailTips is just a subset of those properties, in fact for some reason I always had issues running my integration tests on EXOMailTips whenever it ran along side all other EXO resources whereas by itself using exactly the same blueprints it NEVER failed, don't ask me why.

@FabienTschanz
Copy link
Collaborator

Should I create a PR that removes the EXOMailTips resource and we'll merge that in April when the breaking change is released?

@ricmestre
Copy link
Contributor Author

Yep I'm ok with it

@FabienTschanz FabienTschanz linked a pull request Feb 14, 2025 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Exchange Online
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: Remove EXOMailTips resource FabienTschanz/Microsoft365DSC
3 participants
@ykuijs @FabienTschanz @ricmestre