@jjjordanmsft Can you review this when you have time?

Can you address a few things now that we have a sane generator? (This is not your doing but imo, necessary to complete the change):

• Call the standard generator here instead - and use the fallback code in case err is set. (With the way this is written, this function can not fail).
• Set variant and version only in the case of fallback. Also fix the typo where it should be SetVariant.
• I don't think we need to keep the reader in the uuidGenerator struct anymore, but it's still needed to seed the fallback.

Thanks!

@jjjordanmsft
I wasn't sure what you meant by calling the standard generator, but I assumed you meant calling the provided uuid.NewV4() function instead of using the Contract directly.

I was wondering if I could actually move the

u.SetVersion(uuid.V4)
u.SetVariant(uuid.VariantRFC4122)

to inside the function fallback(u *uuid.UUID){...} after the gen.fallbackRand.Read(u[:])

@kwontae Sorry I wasn't clear, but yes this is exactly what I meant. And yes, it probably makes sense to factor the Set* into fallback, if you'd like. Thanks!

@jjjordanmsft no worries :) Glad I didn't make an incorrect assumption. Factored the Set* into fallback as I think it makes more sense to be there.

Thanks!