Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks #139

Open
metastable-void opened this issue Mar 1, 2023 · 7 comments
Open

Fix memory leaks #139

metastable-void opened this issue Mar 1, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@metastable-void
Copy link
Member

Describe the bug
There is a memory leak related to per-container overrides.

To Reproduce
Steps to reproduce the behavior:

  1. Enable Per-container User-Agent Overrides.
  2. Browse as normal.
  3. Sometimes Firefox becomes unresponsive.

Expected behavior
Operates as normal, causing no memory leaks.

Screenshots
image

Console outputs
If applicable, open about:debugging > This Firefox and select Inspect for this extension. Then copy and paste what is in the console (you can hide your private information, if any).

Nothing interesting.

Firefox (please complete the following information):

  • OS: macOS, arm64
  • Browser edition and version: release 111.0
  • Extension version [e.g. 12] 11.4.0

Additional context
https://discourse.mozilla.org/t/container-tab-groups-memory-leak-with-user-agent-overrides-enabled/111524

@metastable-void metastable-void added the bug Something isn't working label Mar 1, 2023
@metastable-void
Copy link
Member Author

about memory (live measurement).pdf

Memory mesurement for 11.6.0.

@metastable-void
Copy link
Member Author

Here no visible memory leaks are observed.

@metastable-void
Copy link
Member Author

For a permanent and fundamental solution, we are moving to a nonpersistent background page.

@metastable-void
Copy link
Member Author

Fixed possible sources for memory leaks in language overrides codes.

@gmarkley-VI
Copy link

Is this still an issue?

@metastable-void
Copy link
Member Author

@gmarkley-VI Combined with recent updates to Firefox, we do not see major performance issues with the extension, but if you find any, please report it here.

@ttiikeri
Copy link

ttiikeri commented Jan 30, 2025

I had major memory issues with Container Tab Groups so that I had to disable it to not have a big chunk of the memory be spent on with just a few tabs. When I had less than 5 tabs open, about 10-20 percent of memory would still be used, and if the tab count would go 8+, the memory usage jumps to 35-50 %.

Haven't still debugged what's the actual reason for memory leaking, but this is the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants