Skip to content

Commit 74c848d

Browse files
Merge pull request #6 from bsutton/main
Fixed documentation error and re-organised dependencies inline with dart best practices.
2 parents 47b86ba + 2387647 commit 74c848d

8 files changed

+39
-39
lines changed

example/pubspec.lock

+16-15
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ packages:
7676
source: sdk
7777
version: "0.0.0"
7878
http:
79-
dependency: "direct overridden"
79+
dependency: "direct main"
8080
description:
8181
name: http
8282
sha256: "761a297c042deedc1ffbb156d6e2af13886bb305c2a343a4d972504cd67dd938"
@@ -92,36 +92,36 @@ packages:
9292
source: hosted
9393
version: "4.0.2"
9494
june:
95-
dependency: "direct overridden"
95+
dependency: "direct main"
9696
description:
9797
path: ".."
9898
relative: true
9999
source: path
100-
version: "0.8.8"
100+
version: "1.0.0+1"
101101
leak_tracker:
102102
dependency: transitive
103103
description:
104104
name: leak_tracker
105-
sha256: "78eb209deea09858f5269f5a5b02be4049535f568c07b275096836f01ea323fa"
105+
sha256: "7f0df31977cb2c0b88585095d168e689669a2cc9b97c309665e3386f3e9d341a"
106106
url: "https://pub.dev"
107107
source: hosted
108-
version: "10.0.0"
108+
version: "10.0.4"
109109
leak_tracker_flutter_testing:
110110
dependency: transitive
111111
description:
112112
name: leak_tracker_flutter_testing
113-
sha256: b46c5e37c19120a8a01918cfaf293547f47269f7cb4b0058f21531c2465d6ef0
113+
sha256: "06e98f569d004c1315b991ded39924b21af84cf14cc94791b8aea337d25b57f8"
114114
url: "https://pub.dev"
115115
source: hosted
116-
version: "2.0.1"
116+
version: "3.0.3"
117117
leak_tracker_testing:
118118
dependency: transitive
119119
description:
120120
name: leak_tracker_testing
121-
sha256: a597f72a664dbd293f3bfc51f9ba69816f84dcd403cdac7066cb3f6003f3ab47
121+
sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3"
122122
url: "https://pub.dev"
123123
source: hosted
124-
version: "2.0.1"
124+
version: "3.0.1"
125125
lints:
126126
dependency: transitive
127127
description:
@@ -150,10 +150,10 @@ packages:
150150
dependency: transitive
151151
description:
152152
name: meta
153-
sha256: d584fa6707a52763a52446f02cc621b077888fb63b93bbcb1143a7be5a0c0c04
153+
sha256: "7687075e408b093f36e6bbf6c91878cc0d4cd10f409506f7bc996f68220b9136"
154154
url: "https://pub.dev"
155155
source: hosted
156-
version: "1.11.0"
156+
version: "1.12.0"
157157
path:
158158
dependency: transitive
159159
description:
@@ -211,10 +211,10 @@ packages:
211211
dependency: transitive
212212
description:
213213
name: test_api
214-
sha256: "5c2f730018264d276c20e4f1503fd1308dfbbae39ec8ee63c5236311ac06954b"
214+
sha256: "9955ae474176f7ac8ee4e989dadfb411a58c30415bcfb648fa04b2b8a03afa7f"
215215
url: "https://pub.dev"
216216
source: hosted
217-
version: "0.6.1"
217+
version: "0.7.0"
218218
typed_data:
219219
dependency: transitive
220220
description:
@@ -235,10 +235,10 @@ packages:
235235
dependency: transitive
236236
description:
237237
name: vm_service
238-
sha256: b3d56ff4341b8f182b96aceb2fa20e3dcb336b9f867bc0eafc0de10f1048e957
238+
sha256: "3923c89304b715fb1eb6423f017651664a03bf5f4b29983627c4da791f74a4ec"
239239
url: "https://pub.dev"
240240
source: hosted
241-
version: "13.0.0"
241+
version: "14.2.1"
242242
web:
243243
dependency: transitive
244244
description:
@@ -249,3 +249,4 @@ packages:
249249
version: "0.5.1"
250250
sdks:
251251
dart: ">=3.3.0 <4.0.0"
252+
flutter: ">=3.18.0-18.0.pre.54"

example/pubspec.yaml

+1-5
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,9 @@ version: 1.0.0+1
2121
environment:
2222
sdk: '>=3.2.6 <4.0.0'
2323

24-
dependency_overrides:
24+
dependencies:
2525
june:
26-
path: ../
2726
http: ^1.2.1
28-
29-
30-
dependencies:
3127
flutter:
3228
sdk: flutter
3329

example/pubspec_overrides.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
dependency_overrides:
2+
june:
3+
path: ../

lib/state_manager/src/simple/controllers.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'list_notifier.dart';
77

88
// ignore: prefer_mixin
99
abstract class JuneState extends ListNotifier with JuneLifeCycleMixin {
10-
/// Rebuilds `JuneBuilder` each time you call `update()`;
10+
/// Rebuilds `JuneBuilder` each time you call `setState()`;
1111
/// Can take a List of [ids], that will only update the matching
1212
/// `JuneBuilder( id: )`,
1313
/// [ids] can be reused among `JuneBuilders` like group tags.

lib/state_manager/src/simple/simple_builder.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ class StateBuilder<T> extends StatefulWidget {
3030
final void Function(T)? onUpdate;
3131

3232
const StateBuilder({
33-
Key? key,
33+
super.key,
3434
required this.initialValue,
3535
this.onDispose,
3636
this.onUpdate,
3737
required this.builder,
38-
}) : super(key: key);
38+
});
3939

4040
@override
4141
StateBuilderState<T> createState() => StateBuilderState<T>();
@@ -80,7 +80,7 @@ class ObxElement = StatelessElement with StatelessObserverComponent;
8080
class Observer extends ObxStatelessWidget {
8181
final WidgetBuilder builder;
8282

83-
const Observer({Key? key, required this.builder}) : super(key: key);
83+
const Observer({super.key, required this.builder});
8484

8585
@override
8686
Widget build(BuildContext context) => builder(context);
@@ -89,7 +89,7 @@ class Observer extends ObxStatelessWidget {
8989
/// A StatelessWidget than can listen reactive changes.
9090
abstract class ObxStatelessWidget extends StatelessWidget {
9191
/// Initializes [key] for subclasses.
92-
const ObxStatelessWidget({Key? key}) : super(key: key);
92+
const ObxStatelessWidget({super.key});
9393

9494
@override
9595
StatelessElement createElement() => ObxElement(this);

lib/state_manager/src/simple/state.dart

+12-13
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class JuneBuilder<T extends JuneState> extends StatelessWidget {
5353

5454
const JuneBuilder(
5555
this._creator, {
56-
Key? key,
56+
super.key,
5757
this.init,
5858
this.global = true,
5959
required this.builder,
@@ -66,7 +66,7 @@ class JuneBuilder<T extends JuneState> extends StatelessWidget {
6666
this.id,
6767
this.didChangeDependencies,
6868
this.didUpdateWidget,
69-
}) : super(key: key);
69+
});
7070

7171
@override
7272
Widget build(BuildContext context) {
@@ -96,7 +96,7 @@ class JuneBuilder<T extends JuneState> extends StatelessWidget {
9696

9797
abstract class Bind<T> extends StatelessWidget {
9898
const Bind({
99-
Key? key,
99+
super.key,
100100
required this.child,
101101
this.init,
102102
this.global = true,
@@ -109,7 +109,7 @@ abstract class Bind<T> extends StatelessWidget {
109109
this.id,
110110
this.didChangeDependencies,
111111
this.didUpdateWidget,
112-
}) : super(key: key);
112+
});
113113

114114
final InitBuilder<T>? init;
115115

@@ -304,7 +304,7 @@ class _FactoryBind<T> extends Bind<T> {
304304
final Widget? child;
305305

306306
const _FactoryBind({
307-
Key? key,
307+
super.key,
308308
this.child,
309309
this.init,
310310
this.create,
@@ -318,7 +318,7 @@ class _FactoryBind<T> extends Bind<T> {
318318
this.id,
319319
this.didChangeDependencies,
320320
this.didUpdateWidget,
321-
}) : super(key: key, child: child);
321+
}) : super(child: child);
322322

323323
@override
324324
Bind<T> _copyWithChild(Widget child) {
@@ -363,11 +363,10 @@ class Binds extends StatelessWidget {
363363
final Widget child;
364364

365365
Binds({
366-
Key? key,
366+
super.key,
367367
required this.binds,
368368
required this.child,
369-
}) : assert(binds.isNotEmpty),
370-
super(key: key);
369+
}) : assert(binds.isNotEmpty);
371370

372371
@override
373372
Widget build(BuildContext context) =>
@@ -380,8 +379,8 @@ class Binder<T> extends InheritedWidget {
380379
///
381380
/// The [child] argument is required
382381
const Binder({
383-
Key? key,
384-
required Widget child,
382+
super.key,
383+
required super.child,
385384
this.init,
386385
this.global = true,
387386
this.autoRemove = true,
@@ -395,7 +394,7 @@ class Binder<T> extends InheritedWidget {
395394
this.didChangeDependencies,
396395
this.didUpdateWidget,
397396
this.create,
398-
}) : super(key: key, child: child);
397+
});
399398

400399
final InitBuilder<T>? init;
401400
final InstanceCreateBuilderCallback? create;
@@ -427,7 +426,7 @@ class Binder<T> extends InheritedWidget {
427426
/// The BindElement is responsible for injecting dependencies into the widget
428427
/// tree so that they can be observed
429428
class BindElement<T> extends InheritedElement {
430-
BindElement(Binder<T> widget) : super(widget) {
429+
BindElement(Binder<T> super.widget) {
431430
initState();
432431
}
433432

lib/state_manager/src/simple/widget_cache.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:flutter/widgets.dart';
22

33
abstract class JuneWidgetCache extends Widget {
4-
const JuneWidgetCache({Key? key}) : super(key: key);
4+
const JuneWidgetCache({super.key});
55

66
@override
77
JuneWidgetCacheElement createElement() => JuneWidgetCacheElement(this);

pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ dependencies:
1313
sdk: flutter
1414

1515
dev_dependencies:
16+
flutter_lints:
1617
flutter_test:
1718
sdk: flutter
1819

0 commit comments

Comments
 (0)