Skip to content

Commit 09ad8b1

Browse files
author
meetvm
committed
Fix Issue 16890: Hide Stracktrace while translog transfer
Signed-off-by: meetvm <meetvm@amazon.com> Bump com.nimbusds:oauth2-oidc-sdk from 11.19.1 to 11.20.1 in /plugins/repository-azure (opensearch-project#16895) * Bump com.nimbusds:oauth2-oidc-sdk in /plugins/repository-azure Bumps [com.nimbusds:oauth2-oidc-sdk](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions) from 11.19.1 to 11.20.1. - [Changelog](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/branches/compare/11.20.1..11.19.1) --- updated-dependencies: - dependency-name: com.nimbusds:oauth2-oidc-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Bump com.netflix.nebula.ospackage-base from 11.10.0 to 11.10.1 in /distribution/packages (opensearch-project#16896) * Bump com.netflix.nebula.ospackage-base in /distribution/packages Bumps com.netflix.nebula.ospackage-base from 11.10.0 to 11.10.1. --- updated-dependencies: - dependency-name: com.netflix.nebula.ospackage-base dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Bump ch.qos.logback:logback-classic from 1.5.12 to 1.5.15 in /test/fixtures/hdfs-fixture (opensearch-project#16898) * Bump ch.qos.logback:logback-classic in /test/fixtures/hdfs-fixture Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.5.12 to 1.5.15. - [Commits](qos-ch/logback@v_1.5.12...v_1.5.15) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Bump lycheeverse/lychee-action from 2.1.0 to 2.2.0 (opensearch-project#16897) * Bump lycheeverse/lychee-action from 2.1.0 to 2.2.0 Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/lycheeverse/lychee-action/releases) - [Commits](lycheeverse/lychee-action@v2.1.0...v2.2.0) --- updated-dependencies: - dependency-name: lycheeverse/lychee-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Create sub directories for ThirdPartyAudit dependency metadata (opensearch-project#16844) * Extract jars to sub dirs during thirdPartyAudit task. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Change regex to split on '-'/'.'. Ignore version. Signed-off-by: Finn Carroll <carrofin@amazon.com> * Split on .jar for sub folder prefix. Signed-off-by: Finn Carroll <carrofin@amazon.com> --------- Signed-off-by: Finn Carroll <carrofin@amazon.com> Retrieve value from DocValues in a flat_object filed (opensearch-project#16802) Bump com.microsoft.azure:msal4j from 1.17.2 to 1.18.0 in /plugins/repository-azure (opensearch-project#16918) * Bump com.microsoft.azure:msal4j in /plugins/repository-azure Bumps [com.microsoft.azure:msal4j](https://github.com/AzureAD/microsoft-authentication-library-for-java) from 1.17.2 to 1.18.0. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-java/releases) - [Changelog](https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/changelog.txt) - [Commits](AzureAD/microsoft-authentication-library-for-java@v1.17.2...v1.18.0) --- updated-dependencies: - dependency-name: com.microsoft.azure:msal4j dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Bump org.apache.commons:commons-text from 1.12.0 to 1.13.0 in /test/fixtures/hdfs-fixture (opensearch-project#16919) * Bump org.apache.commons:commons-text in /test/fixtures/hdfs-fixture Bumps org.apache.commons:commons-text from 1.12.0 to 1.13.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Add gRPC server as transport-grpc plugin (opensearch-project#16534) Introduce auxiliary transport to NetworkPlugin and add gRPC plugin. Auxiliary transports are optional lifecycle components provided by network plugins which run in parallel to the http server/native transport. They are distinct from the existing NetworkPlugin interfaces of 'getTransports' and 'getHttpTransports' as auxiliary transports are optional. Each AuxTransport implements it's own 'aux.transport.type' and 'aux.transport.<type>.ports' setting. Since Security.java initializes previous to Node.java during bootstrap socket binding permissions are granted based on 'aux.transport.<type>.ports' for each enabled 'aux.transport.type', falling back to a default if no ports are specified. Signed-off-by: Finn Carroll <carrofin@amazon.com> Update script supports java.lang.String.sha1() and java.lang.String.sha256() methods (opensearch-project#16923) * Update script supports java.lang.String.sha1() and java.lang.String.sha256() methods Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Workflow benchmark-pull-request.yml fix (opensearch-project#16925) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Add benchmark confirm for lucene-10 big5 index snapshot (opensearch-project#16940) Signed-off-by: Rishabh Singh <sngri@amazon.com> Remove duplicate DCO check (opensearch-project#16942) Signed-off-by: Andriy Redko <drreta@gmail.com> Allow extended plugins to be optional (opensearch-project#16909) * Make extended plugins optional Signed-off-by: Craig Perkins <cwperx@amazon.com> * Make extended plugins optional Signed-off-by: Craig Perkins <cwperx@amazon.com> * Load extensions for classpath plugins Signed-off-by: Craig Perkins <cwperx@amazon.com> * Ensure only single instance for each classpath extension Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add test for classpath plugin extended plugin loading Signed-off-by: Craig Perkins <cwperx@amazon.com> * Modify test to allow optional extended plugin Signed-off-by: Craig Perkins <cwperx@amazon.com> * Only optional extended plugins Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add additional warning message Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add tag to make extended plugin optional Signed-off-by: Craig Perkins <cwperx@amazon.com> * Only send plugin names when serializing PluginInfo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Keep track of optional extended plugins in separate set Signed-off-by: Craig Perkins <cwperx@amazon.com> * Include in ser/de of PluginInfo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Change to 3_0_0 Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Change version in PluginInfo to V_2_19_0 after backport to 2.x merged (opensearch-project#16947) Signed-off-by: Craig Perkins <cwperx@amazon.com> Support object fields in star-tree index (opensearch-project#16728) --------- Signed-off-by: bharath-techie <bharath78910@gmail.com> Bump ch.qos.logback:logback-core from 1.5.12 to 1.5.16 in /test/fixtures/hdfs-fixture (opensearch-project#16951) * Bump ch.qos.logback:logback-core in /test/fixtures/hdfs-fixture Bumps [ch.qos.logback:logback-core](https://github.com/qos-ch/logback) from 1.5.12 to 1.5.16. - [Commits](qos-ch/logback@v_1.5.12...v_1.5.16) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> [Workload Management] Add Workload Management IT (opensearch-project#16359) * add workload management IT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * address comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> --------- Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> Add new benchmark config for nested workload (opensearch-project#16956) Signed-off-by: Rishabh Singh <sngri@amazon.com> Bump com.azure:azure-core-http-netty from 1.15.5 to 1.15.7 in /plugins/repository-azure (opensearch-project#16952) * Bump com.azure:azure-core-http-netty in /plugins/repository-azure Bumps [com.azure:azure-core-http-netty](https://github.com/Azure/azure-sdk-for-java) from 1.15.5 to 1.15.7. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-core-http-netty_1.15.5...azure-core-http-netty_1.15.7) --- updated-dependencies: - dependency-name: com.azure:azure-core-http-netty dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Always use constant_score query for match_only_text (opensearch-project#16964) In some cases, when we create a term query over a `match_only_text` field, it may still try to compute scores, which prevents early termination. We should *always* use a constant score query when querying `match_only_text`, since we don't have the statistics required to compute scores. --------- Signed-off-by: Michael Froh <froh@amazon.com> Changes to support unmapped fields in metric aggregation (opensearch-project#16481) Avoids exception when querying unmapped field when star tree experimental feature is enables. --------- Signed-off-by: expani <anijainc@amazon.com> Use async client for delete blob or path in S3 Blob Container (opensearch-project#16788) * Use async client for delete blob or path in S3 Blob Container Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix UTs Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix failures in S3BlobStoreRepositoryTests Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix S3BlobStoreRepositoryTests Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix failures in S3RepositoryThirdPartyTests Signed-off-by: Ashish Singh <ssashish@amazon.com> * Fix failures in S3RepositoryPluginTests Signed-off-by: Ashish Singh <ssashish@amazon.com> --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> Fix Shallow copy snapshot failures on closed index (opensearch-project#16868) * Fix shallow v1 snapshot failures on closed index Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * UT fix Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Adding UT Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * small fix Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Addressing comments Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Addressing comments Signed-off-by: Shubh Sahu <shubhvs@amazon.com> * Modifying IT to restore snapshot Signed-off-by: Shubh Sahu <shubhvs@amazon.com> --------- Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Co-authored-by: Shubh Sahu <shubhvs@amazon.com> Add Response Status Number in http trace logs. (opensearch-project#16978) Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> support termQueryCaseInsensitive/termQuery can search from doc_value in flat_object/keyword field (opensearch-project#16974) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> use the correct type to widen the sort fields when merging top docs (opensearch-project#16881) * use the correct type to widen the sort fields when merging top docs Signed-off-by: panguixin <panguixin@bytedance.com> * fix Signed-off-by: panguixin <panguixin@bytedance.com> * apply commments Signed-off-by: panguixin <panguixin@bytedance.com> * changelog Signed-off-by: panguixin <panguixin@bytedance.com> * add more tests Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Fix multi-value sort for unsigned long (opensearch-project#16732) * Fix multi-value sort for unsigned long Signed-off-by: panguixin <panguixin@bytedance.com> * Add initial rest-api-spec tests Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * add more rest tests Signed-off-by: panguixin <panguixin@bytedance.com> * fix Signed-off-by: panguixin <panguixin@bytedance.com> * fix Signed-off-by: panguixin <panguixin@bytedance.com> * Extend MultiValueMode with dedicated support of unsigned_long doc values Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Add CHANGELOG.md, minor cleanups Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Correct the license headers Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Correct the @publicapi version Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Replace SingletonSortedNumericUnsignedLongValues with LongToSortedNumericUnsignedLongValues (as per review comments) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Update Gradle to 8.12 (opensearch-project#16884) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> `phone-search` analyzer: don't emit sip/tel prefix, int'l prefix, extension & unformatted input (opensearch-project#16993) * `phone-search` analyzer: don't emit int'l prefix this was an oversight in the initial implementation: if the tokenizer emits the international calling prefix in the search analyzer then all documents with the same international calling prefix will match. e.g. when searching for `+1-555-123-4567` not only documents with this number would match but also any other document with a `1` token (i.e. any other number with this prefix). thus the search functionality is currently broken for this analyzer, making it useless. the test coverage has now been extended to cover these and other use-cases. Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> * `phone-search` analyzer: don't emit extension & unformatted input if these tokens are emitted it meant that phone numbers with other international dialling prefixes still matched. e.g. searching for `+1 1234` would also match a number stored as `+2 1234`, which was wrong. the tokens still need to be emited for the `phone` analyzer, e.g. when the user only enters the extension / local number it should still match, the same is with the other ngrams: these are needed for search-as-you-type style queries where the user input needs to match against partial phone numbers. Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> * `phone-search` analyzer: don't emit sip/tel prefix in line with the previous two commits, this is something else the search analyzer shouldn't emit since otherwise searching for any number with such a prefix will match _any_ document with the same prefix. Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> --------- Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> Limit RW separation to remote store enabled clusters and update recovery flow (opensearch-project#16760) * Update search only replica recovery flow This PR includes multiple changes to search replica recovery. 1. Change search only replica copies to recover as empty store instead of PEER. This will run a store recovery that syncs segments from remote store directly and eliminate any primary communication. 2. Remove search replicas from the in-sync allocation ID set and update routing table to exclude them from allAllocationIds. This ensures primaries aren't tracking or validating the routing table for any search replica's presence. 3. Change search replica validation to require remote store. There are versions of the above changes that are still possible with primary based node-node replication, but I don't think they are worth making at this time. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * more coverage Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * add changelog entry Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * add assertions that Search Replicas are not in the in-sync id set nor the AllAllocationIds set in the routing table Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * update async task to only run if the FF is enabled and we are a remote store cluster. This check had previously only checked for segrep Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * clean up max shards logic Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * remove search replicas from check during renewPeerRecoveryRetentionLeases Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Revert "update async task to only run if the FF is enabled and we are a remote store cluster." reverting this, we already check for remote store earlier. This reverts commit 48ca1a3. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Add more tests for failover case Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Update remotestore restore logic and add test ensuring we can restore only writers when red Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix Search replicas to honor node level recovery limits Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix translog UUID mismatch on existing store recovery. This commit adds PR feedback and recovery tests post node restart. Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix spotless Signed-off-by: Marc Handalian <marc.handalian@gmail.com> * Fix bug with remote restore and add more tests Signed-off-by: Marc Handalian <marc.handalian@gmail.com> --------- Signed-off-by: Marc Handalian <marc.handalian@gmail.com> Fix case insensitive and escaped query on wildcard (opensearch-project#16827) * fix case insensitive and escaped query on wildcard Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com> * add changelog Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com> --------- Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com> Signed-off-by: Michael Froh <froh@amazon.com> Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com> Co-authored-by: Michael Froh <froh@amazon.com> Bump opentelemetry from 1.41.0 to 1.46.0 and opentelemetry-semconv from 1.27.0-alpha to 1.29.0-alpha (opensearch-project#17000) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> TransportBulkAction.doRun() (opensearch-project#16950) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Show only intersecting buckets to the Adjacency matrix aggregation (opensearch-project#11733) Signed-off-by: Ivan Brusic <ivan@brusic.com> Bump com.google.re2j:re2j from 1.7 to 1.8 in /plugins/repository-hdfs (opensearch-project#17012) * Bump com.google.re2j:re2j from 1.7 to 1.8 in /plugins/repository-hdfs Bumps [com.google.re2j:re2j](https://github.com/google/re2j) from 1.7 to 1.8. - [Release notes](https://github.com/google/re2j/releases) - [Commits](google/re2j@re2j-1.7...re2j-1.8) --- updated-dependencies: - dependency-name: com.google.re2j:re2j dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump com.nimbusds:oauth2-oidc-sdk from 11.20.1 to 11.21 in /plugins/repository-azure (opensearch-project#17010) * Bump com.nimbusds:oauth2-oidc-sdk in /plugins/repository-azure Bumps [com.nimbusds:oauth2-oidc-sdk](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions) from 11.20.1 to 11.21. - [Changelog](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/branches/compare/11.21..11.20.1) --- updated-dependencies: - dependency-name: com.nimbusds:oauth2-oidc-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> improve `PhoneNumberAnalyzerTests#testTelPrefixSearch` (opensearch-project#17016) this way we ensure that it doesn't include any additional tokens which we don't want. this is a follow-up to commit 4d94399 / opensearch-project#16993. Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> Filter shards for sliced search at coordinator (opensearch-project#16771) * Filter shards for sliced search at coordinator Prior to this commit, a sliced search would fan out to every shard, then apply a MatchNoDocsQuery filter on shards that don't correspond to the current slice. This still creates a (useless) search context on each shard for every slice, though. For a long-running sliced scroll, this can quickly exhaust the number of available scroll contexts. This change avoids fanning out to all the shards by checking at the coordinator if a shard is matched by the current slice. This should reduce the number of open scroll contexts to max(numShards, numSlices) instead of numShards * numSlices. --------- Signed-off-by: Michael Froh <froh@amazon.com> Upgrade HttpCore5/HttpClient5 to support ExtendedSocketOption in HttpAsyncClient (opensearch-project#16757) * upgrade httpcore5/httpclient5 to support ExtendedSocketOption in HttpAsyncClient Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> * Use the Upgrade flow by default Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update Reactor Netty to 1.1.26.Final Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Add SETTING_H2C_MAX_CONTENT_LENGTH to configure h2cMaxContentLength for reactor-netty4 transport Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update Apache HttpCore5 to 5.3.2 Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Update version checks for backport (opensearch-project#17030) Signed-off-by: Michael Froh <froh@amazon.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Michael Froh <froh@amazon.com> Fix versions and breaking API changes (opensearch-project#17031) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Bump com.nimbusds:nimbus-jose-jwt from 9.47 to 10.0.1 in /test/fixtures/hdfs-fixture (opensearch-project#17011) * Bump com.nimbusds:nimbus-jose-jwt in /test/fixtures/hdfs-fixture Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.47 to 10.0.1. - [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0.1..9.47) --- updated-dependencies: - dependency-name: com.nimbusds:nimbus-jose-jwt dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Remove user data from logs when not in debug/trace mode (opensearch-project#17007) * Remove user data from logs when not in debug/trace mode Signed-off-by: Mohit Godwani <mgodwan@amazon.com> Remove user data from logs when not in debug/trace mode (opensearch-project#17007) * Remove user data from logs when not in debug/trace mode Signed-off-by: Mohit Godwani <mgodwan@amazon.com> Signed-off-by: meetvm <meetvm@amazon.com> [Bugfix] Fix cache maximum size settings not working properly with pluggable caching (opensearch-project#16636) * Fix cache size setting Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Changelog Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Deprecate original IRC size setting Signed-off-by: Peter Alfonsi <petealft@amazon.com> * spotlessApply Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Addressed Ankit's comments Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Address Sagar's comment Signed-off-by: Peter Alfonsi <petealft@amazon.com> --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com> Signed-off-by: meetvm <meetvm@amazon.com> Fix GRPC AUX_TRANSPORT_PORT and SETTING_GRPC_PORT settings and remove lingering HTTP terminology (opensearch-project#17037) * [GRPC] Rename AUX_TRANSPORT_PORT and SETTING_GRPC_PORT settings and remove lingering HTTP terminology Signed-off-by: Karen Xu <karenxyr@gmail.com> * Update CHANGELOG Signed-off-by: Karen Xu <karenxyr@gmail.com> * remove extra space in CHANGELOG Signed-off-by: Karen Xu <karenxyr@gmail.com> * Update plugins/transport-grpc/src/main/java/org/opensearch/transport/grpc/Netty4GrpcServerTransport.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Karen X <karenxyr@gmail.com> --------- Signed-off-by: Karen Xu <karenxyr@gmail.com> Signed-off-by: Karen X <karenxyr@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: meetvm <meetvm@amazon.com> Bump com.nimbusds:nimbus-jose-jwt from 9.47 to 10.0.1 in /test/fixtures/hdfs-fixture (opensearch-project#17011) * Bump com.nimbusds:nimbus-jose-jwt in /test/fixtures/hdfs-fixture Bumps [com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt) from 9.47 to 10.0.1. - [Changelog](https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/CHANGELOG.txt) - [Commits](https://bitbucket.org/connect2id/nimbus-jose-jwt/branches/compare/10.0.1..9.47) --- updated-dependencies: - dependency-name: com.nimbusds:nimbus-jose-jwt dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update changelog Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Remove user data from logs when not in debug/trace mode (opensearch-project#17007) * Remove user data from logs when not in debug/trace mode Signed-off-by: Mohit Godwani <mgodwan@amazon.com> [Bugfix] Fix cache maximum size settings not working properly with pluggable caching (opensearch-project#16636) * Fix cache size setting Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Changelog Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Deprecate original IRC size setting Signed-off-by: Peter Alfonsi <petealft@amazon.com> * spotlessApply Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Addressed Ankit's comments Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Address Sagar's comment Signed-off-by: Peter Alfonsi <petealft@amazon.com> --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com> Signed-off-by: Ankit Jain <akjain@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Ankit Jain <akjain@amazon.com> Fix GRPC AUX_TRANSPORT_PORT and SETTING_GRPC_PORT settings and remove lingering HTTP terminology (opensearch-project#17037) * [GRPC] Rename AUX_TRANSPORT_PORT and SETTING_GRPC_PORT settings and remove lingering HTTP terminology Signed-off-by: Karen Xu <karenxyr@gmail.com> * Update CHANGELOG Signed-off-by: Karen Xu <karenxyr@gmail.com> * remove extra space in CHANGELOG Signed-off-by: Karen Xu <karenxyr@gmail.com> * Update plugins/transport-grpc/src/main/java/org/opensearch/transport/grpc/Netty4GrpcServerTransport.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Karen X <karenxyr@gmail.com> --------- Signed-off-by: Karen Xu <karenxyr@gmail.com> Signed-off-by: Karen X <karenxyr@gmail.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Fix getTime field name to time in GetStats (opensearch-project#16894) (opensearch-project#17009) * Fix getTime field name to time in GetStats (opensearch-project#16894) Signed-off-by: hye-on <ain0103@naver.com> * Update PR number in changelog Signed-off-by: hye-on <ain0103@naver.com> * Deprecate getTime field and add time field in GetStats for backward compatibility Signed-off-by: hye-on <ain0103@naver.com> * Add forRemoval flag to getTime field for future removal Signed-off-by: hye-on <ain0103@naver.com> * Changed to use field instead of humanReadableField for GET_TIME in JSON response Replaced the use of builder.humanReadableField for the GET_TIME field with builder.field(Fields.GET_TIME, Objects.toString(getTime())). This prevents the duplication of the time_in_millis field. Signed-off-by: hye-on <ain0103@naver.com> * Add test to validate getTime and time fields in _stats API response getTime and time fields are verified to be included in the _stats API response and correctly aligned. Signed-off-by: hye-on <ain0103@naver.com> * Fix formatting in GetStats.java Signed-off-by: hye-on <ain0103@naver.com> * Rename test file to better reflect test purpose Signed-off-by: hye-on <ain0103@naver.com> * Test Add skip version for stats API human filter test under 2.19.99 Signed-off-by: hye-on <ain0103@naver.com> * Remove unnecessary changelog entries Signed-off-by: hye-on <ain0103@naver.com> * Add a line for styling purposes Signed-off-by: hye-on <ain0103@naver.com> --------- Signed-off-by: hye-on <ain0103@naver.com> Add Craig Perkins as OpenSearch Maintainer (opensearch-project#17046) Signed-off-by: Daniel Widdis <widdis@gmail.com> Update CODEOWNERS (opensearch-project#17053) Signed-off-by: Daniel Widdis <widdis@gmail.com> Improve exception handling in S3BlobContainer synchronous operations (opensearch-project#17049) Signed-off-by: Ashish Singh <ssashish@amazon.com>
1 parent 634b84a commit 09ad8b1

File tree

35 files changed

+696
-110
lines changed

35 files changed

+696
-110
lines changed

.github/CODEOWNERS

+10-10
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,27 @@
1111
# 3. Use the command palette to run the CODEOWNERS: Show owners of current file command, which will display all code owners for the current file.
1212

1313
# Default ownership for all repo files
14-
* @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jainankitk @kotwanikunal @linuxpi @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
14+
* @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @cwperks @dblock @dbwiddis @gbbafna @jainankitk @kotwanikunal @linuxpi @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
1515

1616
/modules/lang-painless/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
1717
/modules/parent-join/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
1818
/modules/transport-netty4/ @peternied
1919

20-
/plugins/identity-shiro/ @peternied
20+
/plugins/identity-shiro/ @peternied @cwperks
2121

22-
/server/src/internalClusterTest/java/org/opensearch/index/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
23-
/server/src/internalClusterTest/java/org/opensearch/search/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
22+
/server/src/internalClusterTest/java/org/opensearch/index/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @cwperks @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
23+
/server/src/internalClusterTest/java/org/opensearch/search/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @cwperks @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
2424

2525
/server/src/main/java/org/opensearch/extensions/ @peternied
26-
/server/src/main/java/org/opensearch/identity/ @peternied
27-
/server/src/main/java/org/opensearch/index/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
28-
/server/src/main/java/org/opensearch/search/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
26+
/server/src/main/java/org/opensearch/identity/ @peternied @cwperks
27+
/server/src/main/java/org/opensearch/index/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @cwperks @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
28+
/server/src/main/java/org/opensearch/search/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @cwperks @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
2929
/server/src/main/java/org/opensearch/threadpool/ @jed326 @peternied
3030
/server/src/main/java/org/opensearch/transport/ @peternied
3131

32-
/server/src/test/java/org/opensearch/index/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
33-
/server/src/test/java/org/opensearch/search/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
32+
/server/src/test/java/org/opensearch/index/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @cwperks @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
33+
/server/src/test/java/org/opensearch/search/ @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @cwperks @dblock @dbwiddis @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
3434

3535
/.github/ @jed326 @peternied
3636

37-
/MAINTAINERS.md @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @dblock @dbwiddis @gaobinlong @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @peternied @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah
37+
/MAINTAINERS.md @anasalkouz @andrross @ashking94 @Bukhtawar @CEHENKLE @cwperks @dblock @dbwiddis @gaobinlong @gbbafna @jed326 @kotwanikunal @mch2 @msfroh @nknize @owaiskazi19 @peternied @reta @Rishikesh1159 @sachinpkale @saratvemulapalli @shwetathareja @sohami @VachaShah

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
3131
- Changes to support IP field in star tree indexing([#16641](https://github.com/opensearch-project/OpenSearch/pull/16641/))
3232
- Support object fields in star-tree index([#16728](https://github.com/opensearch-project/OpenSearch/pull/16728/))
3333
- Support searching from doc_value using termQueryCaseInsensitive/termQuery in flat_object/keyword field([#16974](https://github.com/opensearch-project/OpenSearch/pull/16974/))
34+
- Added a new `time` field to replace the deprecated `getTime` field in `GetStats`. ([#17009](https://github.com/opensearch-project/OpenSearch/pull/17009))
3435

3536
### Dependencies
3637
- Bump `com.google.cloud:google-cloud-core-http` from 2.23.0 to 2.47.0 ([#16504](https://github.com/opensearch-project/OpenSearch/pull/16504))
@@ -75,6 +76,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
7576

7677
### Deprecated
7778
- Performing update operation with default pipeline or final pipeline is deprecated ([#16712](https://github.com/opensearch-project/OpenSearch/pull/16712))
79+
- Marked `getTime` field as deprecated in favor of the new `time` field. ([#17009](https://github.com/opensearch-project/OpenSearch/pull/17009))
7880

7981
### Removed
8082

@@ -95,10 +97,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
9597
- Fix case insensitive and escaped query on wildcard ([#16827](https://github.com/opensearch-project/OpenSearch/pull/16827))
9698
- Fix _list/shards API failing when closed indices are present ([#16606](https://github.com/opensearch-project/OpenSearch/pull/16606))
9799
- Fix remote shards balance ([#15335](https://github.com/opensearch-project/OpenSearch/pull/15335))
100+
- Fix max request cache size settings not working properly with pluggable caching ([#16636](https://github.com/opensearch-project/OpenSearch/pull/16636))
98101
- Always use `constant_score` query for `match_only_text` field ([#16964](https://github.com/opensearch-project/OpenSearch/pull/16964))
99102
- Fix Shallow copy snapshot failures on closed index ([#16868](https://github.com/opensearch-project/OpenSearch/pull/16868))
100103
- Fix multi-value sort for unsigned long ([#16732](https://github.com/opensearch-project/OpenSearch/pull/16732))
101104
- The `phone-search` analyzer no longer emits the tel/sip prefix, international calling code, extension numbers and unformatted input as a token ([#16993](https://github.com/opensearch-project/OpenSearch/pull/16993))
105+
- Fix GRPC AUX_TRANSPORT_PORT and SETTING_GRPC_PORT settings and remove lingering HTTP terminology ([#17037](https://github.com/opensearch-project/OpenSearch/pull/17037))
102106

103107
### Security
104108

MAINTAINERS.md

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ This document contains a list of maintainers in this repo. See [opensearch-proje
1313
| Ashish Singh | [ashking94](https://github.com/ashking94) | Amazon |
1414
| Bukhtawar Khan | [Bukhtawar](https://github.com/Bukhtawar) | Amazon |
1515
| Charlotte Henkle | [CEHENKLE](https://github.com/CEHENKLE) | Amazon |
16+
| Craig Perkins | [cwperks](https://github.com/cwperks) | Amazon |
1617
| Dan Widdis | [dbwiddis](https://github.com/dbwiddis) | Amazon |
1718
| Daniel "dB." Doubrovkine | [dblock](https://github.com/dblock) | Amazon |
1819
| Gao Binlong | [gaobinlong](https://github.com/gaobinlong) | Amazon |

modules/cache-common/src/main/java/org/opensearch/cache/common/tier/TieredSpilloverCache.java

+15
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,9 @@ static class TieredSpilloverCacheSegment<K, V> implements ICache<K, V> {
150150

151151
private final TieredSpilloverCacheStatsHolder statsHolder;
152152

153+
private final long onHeapCacheMaxWeight;
154+
private final long diskCacheMaxWeight;
155+
153156
/**
154157
* This map is used to handle concurrent requests for same key in computeIfAbsent() to ensure we load the value
155158
* only once.
@@ -218,6 +221,8 @@ static class TieredSpilloverCacheSegment<K, V> implements ICache<K, V> {
218221
cacheListMap.put(diskCache, new TierInfo(isDiskCacheEnabled, TIER_DIMENSION_VALUE_DISK));
219222
this.caches = Collections.synchronizedMap(cacheListMap);
220223
this.policies = builder.policies; // Will never be null; builder initializes it to an empty list
224+
this.onHeapCacheMaxWeight = onHeapCacheSizeInBytes;
225+
this.diskCacheMaxWeight = diskCacheSizeInBytes;
221226
}
222227

223228
// Package private for testing
@@ -526,6 +531,16 @@ void updateStatsOnPut(String destinationTierValue, ICacheKey<K> key, V value) {
526531
statsHolder.incrementSizeInBytes(dimensionValues, weigher.applyAsLong(key, value));
527532
}
528533

534+
// pkg-private for testing
535+
long getOnHeapCacheMaxWeight() {
536+
return onHeapCacheMaxWeight;
537+
}
538+
539+
// pkg-private for testing
540+
long getDiskCacheMaxWeight() {
541+
return diskCacheMaxWeight;
542+
}
543+
529544
/**
530545
* A class which receives removal events from the heap tier.
531546
*/

modules/cache-common/src/main/java/org/opensearch/cache/common/tier/TieredSpilloverCacheSettings.java

+6
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ public class TieredSpilloverCacheSettings {
8585

8686
/**
8787
* Setting which defines the onHeap cache size to be used within tiered cache.
88+
* This setting overrides size settings from the heap tier implementation.
89+
* For example, if OpenSearchOnHeapCache is the heap tier in the request cache, and
90+
* indices.requests.cache.opensearch_onheap.size is set, that value will be ignored in favor of this setting.
8891
*
8992
* Pattern: {cache_type}.tiered_spillover.onheap.store.size
9093
* Example: indices.request.cache.tiered_spillover.onheap.store.size
@@ -96,6 +99,9 @@ public class TieredSpilloverCacheSettings {
9699

97100
/**
98101
* Setting which defines the disk cache size to be used within tiered cache.
102+
* This setting overrides the size setting from the disk tier implementation.
103+
* For example, if EhcacheDiskCache is the disk tier in the request cache, and
104+
* indices.requests.cache.ehcache_disk.max_size_in_bytes is set, that value will be ignored in favor of this setting.
99105
*/
100106
public static final Setting.AffixSetting<Long> TIERED_SPILLOVER_DISK_STORE_SIZE = Setting.suffixKeySetting(
101107
TieredSpilloverCache.TieredSpilloverCacheFactory.TIERED_SPILLOVER_CACHE_NAME + ".disk.store.size",

modules/cache-common/src/test/java/org/opensearch/cache/common/tier/MockDiskCache.java

+4
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,10 @@ public void close() {
128128

129129
}
130130

131+
long getMaximumWeight() {
132+
return maxSize;
133+
}
134+
131135
public static class MockDiskCacheFactory implements Factory {
132136

133137
public static final String NAME = "mockDiskCache";

0 commit comments

Comments
 (0)