Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add rangekey support for Tables #39

Open
tnbred opened this issue Aug 30, 2012 · 6 comments
Open

Need to add rangekey support for Tables #39

tnbred opened this issue Aug 30, 2012 · 6 comments
Assignees

Comments

@tnbred
Copy link
Collaborator

tnbred commented Aug 30, 2012

Currently the Table model doesn't support the RangeKey

@ghost ghost assigned tnbred Aug 30, 2012
@thughes
Copy link
Contributor

thughes commented Sep 11, 2012

Is this feature actively being worked on? (I'm not sure I have time to work on this at the moment, but wanted to see what the status was in case I had time in the future.)

@tnbred
Copy link
Collaborator Author

tnbred commented Sep 11, 2012

Not in the next couple of weeks since we don't need that for our project and it involves some restructuring of the classes. If you find some time feel free to go for it :-)

@rrutt
Copy link
Contributor

rrutt commented Oct 21, 2012

I have a pending Pull Request where I added this support. As tnbredillet indicated, it required adding another nesting layer to the Table.items collection via a new ItemRangeGroup class. It also required reworking various AlternatorDBHandler methods to be aware of the extra nesting.

If you want to experiment with this revision, you can obtain it from my forked repository branch 'range-key-support':

https://github.com/rrutt/Alternator/tree/range-key-support

@mboudreau
Copy link
Owner

Pull request granted, need to revise code.

@rrutt
Copy link
Contributor

rrutt commented Jan 29, 2013

Pull request 49 from *thughes" provided "Fix deleting item with range key".

#49

I have also discovered that query with a RangeCondition against a table with a numeric Range Key was also failing. I have this fixed in my own forked repository. I will be preparing a branch for submission as a Pull Request sometime this week.

@rrutt
Copy link
Contributor

rrutt commented Jan 31, 2013

I submitted my fixes for .query against a table with a numeric Range Key as Pull request 50:

#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants