Skip to content
This repository has been archived by the owner on Feb 24, 2025. It is now read-only.

feat(types): convert exports to explicit type exports #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kad-busses
Copy link

Description

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

Types cannot be re-exported when using the --isolatedModules TypeScript compiler flag. For some transpilers (Babel for example) this flag is mandatory, making it impossible to add this package.

TypeScript has a Type-Only Imports and Export feature, which addresses this issue. This PR converts the type exports to explicit types.

Closes #69

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@trevormil
Copy link

Running into the same problem. I am doing this manually. Would love for this to be added to the npm package :)

@truonghaha
Copy link

Hi team, we are experiencing the same issue. Just wonder why this PR has been open for a year without approval? 😅

@trevormil
Copy link

Hi team, we are experiencing the same issue. Just wonder why this PR has been open for a year without approval? 😅

Hey.

If you need, I created a fork with this fixed at

npm i @trevormil/bbs-signatures

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript error: Cannot re-export a type when the '--isolatedModules' flag is provided
4 participants