Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking space constrains #13

Open
RobinU434 opened this issue Feb 20, 2025 · 0 comments
Open

Checking space constrains #13

RobinU434 opened this issue Feb 20, 2025 · 0 comments

Comments

@RobinU434
Copy link
Contributor

Dear development team,

during this years edition of the rl project, we made a stupid mistake, and we predicted actions outside the boundaries of the environment. We noticed this bug by only looking into individual actions. But you could also intercept this in the step function by checking if the action space contains the given action.
Is there a reason why this is not implemented?

I you wish I will open up a pull request shortly with the necessary changes.

Further, we noticed that shooting is not symmetric given the Box(-1,1), but the decision boundary lies at 0.5. Again, is there a reason for it?

All the best,
Robin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant