[MIG] purchase_manual_delivery: Migration to 16.0

Author: PauBForgeFlow

purchase_manual_delivery/__manifest__.py

@@ -8,7 +8,7 @@
         and adds the ability to manually generate them as the supplier confirms
         the different purchase order lines.
     """,
-    "version": "14.0.1.0.1",
+    "version": "16.0.1.0.0",
     "license": "AGPL-3",
     "author": "ForgeFlow S.L.," "Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/purchase-workflow",

purchase_manual_delivery/models/purchase_order.py

@@ -24,6 +24,7 @@ def _compute_pending_to_receive(self):
 
     def button_confirm_manual(self):
         super(PurchaseOrder, self.with_context(manual_delivery=True)).button_confirm()
+        return
 
     def _create_picking(self):
         if self.env.context.get("manual_delivery", False) and self.manual_delivery:
@@ -38,7 +39,7 @@ class PurchaseOrderLine(models.Model):
 
     existing_qty = fields.Float(
         compute="_compute_existing_qty",
-        string="Existing Qty",
+        string="Existing Quantity",
         digits="Product Unit of Measure",
         help="Quantity already planned or shipped (stock movements " "already created)",
     )

purchase_manual_delivery/tests/test_purchase_manual_delivery.py

@@ -97,7 +97,7 @@ def test_01_purchase_order_manual_delivery(self):
         wizard = (
             self.env["create.stock.picking.wizard"]
             .with_context(
-                {
+                **{
                     "active_model": "purchase.order",
                     "active_id": self.po1.id,
                     "active_ids": self.po1.ids,
@@ -121,7 +121,7 @@ def test_01_purchase_order_manual_delivery(self):
         wizard = (
             self.env["create.stock.picking.wizard"]
             .with_context(
-                {
+                **{
                     "active_model": "purchase.order",
                     "active_id": self.po1.id,
                     "active_ids": self.po1.ids,
@@ -143,7 +143,7 @@ def test_01_purchase_order_manual_delivery(self):
         wizard = (
             self.env["create.stock.picking.wizard"]
             .with_context(
-                {
+                **{
                     "active_model": "purchase.order",
                     "active_id": self.po1.id,
                     "active_ids": self.po1.ids,
@@ -182,7 +182,7 @@ def test_02_purchase_order_line_manual_delivery(self):
         with self.assertRaises(UserError):
             # create a manual delivery for two lines different PO
             self.env["create.stock.picking.wizard"].with_context(
-                {
+                **{
                     "active_model": "purchase.order.line",
                     "active_ids": [self.po1_line1.id, self.po2_line1.id],
                 }
@@ -192,7 +192,7 @@ def test_02_purchase_order_line_manual_delivery(self):
         wizard = (
             self.env["create.stock.picking.wizard"]
             .with_context(
-                {
+                **{
                     "active_model": "purchase.order.line",
                     "active_ids": self.po2.order_line.ids,
                 }
@@ -232,7 +232,7 @@ def test_03_purchase_order_line_location(self):
         wizard = (
             self.env["create.stock.picking.wizard"]
             .with_context(
-                {
+                **{
                     "active_model": "purchase.order",
                     "active_id": self.po1.id,
                     "active_ids": self.po1.ids,

purchase_manual_delivery/wizard/create_manual_stock_picking.py

@@ -4,8 +4,6 @@
 from odoo import _, api, fields, models
 from odoo.exceptions import UserError
 
-from odoo.addons import decimal_precision as dp
-
 
 class CreateManualStockPickingWizard(models.TransientModel):
     _name = "create.stock.picking.wizard"
@@ -191,22 +189,22 @@ class CreateManualStockPickingWizardLine(models.TransientModel):
     product_qty = fields.Float(
         string="Quantity",
         related="purchase_order_line_id.product_qty",
-        digits=dp.get_precision("Product Unit of Measure"),
+        digits="Product Unit of Measure",
     )
     existing_qty = fields.Float(
         string="Existing Quantity",
         related="purchase_order_line_id.existing_qty",
-        digits=dp.get_precision("Product Unit of Measure"),
+        digits="Product Unit of Measure",
     )
     remaining_qty = fields.Float(
         string="Remaining Quantity",
         compute="_compute_remaining_qty",
         readonly=True,
-        digits=dp.get_precision("Product Unit of Measure"),
+        digits="Product Unit of Measure",
     )
     qty = fields.Float(
         string="Quantity to Receive",
-        digits=dp.get_precision("Product Unit of Measure"),
+        digits="Product Unit of Measure",
         help="This is the quantity taken into account to create the picking",
     )
     price_unit = fields.Float(

purchase_manual_delivery/wizard/create_manual_stock_picking.xml

@@ -23,22 +23,20 @@
                         groups="stock.group_stock_multi_locations"
                     />
                 </group>
-                <group>
-                    <field name="line_ids" nolabel="1">
-                        <tree create="false" editable="bottom">
-                            <field name="purchase_order_line_id" invisible="1" />
-                            <field name="product_id" />
-                            <field name="partner_id" />
-                            <field name="date_planned" />
-                            <field name="price_unit" />
-                            <field name="product_qty" string="Ordered Qty" />
-                            <field name="existing_qty" string="Existing Qty" />
-                            <field name="remaining_qty" string="Remaining Qty" />
-                            <field name="qty" string="Quantity" />
-                            <field name="product_uom" groups="uom.group_uom" />
-                        </tree>
-                    </field>
-                </group>
+                <field name="line_ids" nolabel="1">
+                    <tree create="false" editable="bottom">
+                        <field name="purchase_order_line_id" invisible="1" />
+                        <field name="product_id" />
+                        <field name="partner_id" />
+                        <field name="date_planned" />
+                        <field name="price_unit" />
+                        <field name="product_qty" string="Ordered Qty" />
+                        <field name="existing_qty" string="Existing Qty" />
+                        <field name="remaining_qty" string="Remaining Qty" />
+                        <field name="qty" string="Quantity" />
+                        <field name="product_uom" groups="uom.group_uom" />
+                    </tree>
+                </field>
                 <footer>
                     <button
                         name="create_stock_picking"