Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard fork at django-ltree-2 #21

Open
baseplate-admin opened this issue Feb 22, 2024 · 12 comments
Open

Hard fork at django-ltree-2 #21

baseplate-admin opened this issue Feb 22, 2024 · 12 comments

Comments

@baseplate-admin
Copy link
Contributor

baseplate-admin commented Feb 22, 2024

Hi,

I don't think this repository is in development anymore, I have a fork at django-ltree-2 which addresses :

Along with some new features available in python :

Along with automatic label generation

Along with documentation

The test suits are identical. The project is a drop in replacement for django-ltree.

I am open to collaborations, if django-ltree is open to development, I will archive the fork.

Thanks a bunch

@mariocesar
Copy link
Owner

Thank you, @baseplate-admin! I really appreciate your stepping in for the existing users

@mariocesar mariocesar pinned this issue Dec 17, 2024
@baseplate-admin
Copy link
Contributor Author

baseplate-admin commented Dec 17, 2024

Heey, thanks for reaching out, if this package is maintained, i dont see the reason to continue development of django-ltree-2, ( if you wish, i can archive django-ltree-2 )

Judging by

If you need any help ( or want to merge some changes back ) i would be very glad to help you.

Thanks and welcome back :D

@mariocesar
Copy link
Owner

Thanks, @baseplate-admin! I'm happy with that. I'm currently fixing local things for the project, but I can merge your fork, and we can continue together.

To bless this, you can create a "Merge django-ltree-2" ticket, and we can work together there in a branch for the merge.

@baseplate-admin
Copy link
Contributor Author

To bless this, you can create a "Merge django-ltree-2" ticket, and we can work together there in a branch for the merge.

Sounds very very good proposal :)

I would be very willing to merge our project.

Do you have anything that you dont like?
These are 3 extra features i added:

@mariocesar
Copy link
Owner

The three are great !

baseplate-admin/django-ltree-2#3
baseplate-admin/django-ltree-2#4
baseplate-admin/django-ltree-2#11

@baseplate-admin
Copy link
Contributor Author

baseplate-admin commented Dec 19, 2024

Hi, I have submitted PR for all the improvements that i had.

Also i have a new proposal to get path value:

But i am afraid this is a breaking change, it will require the release of a new version.

on a side note, i think you should add some more maintainers to this repository, so that if you need some time off, they can take some of the burden off you

@mariocesar
Copy link
Owner

Thanks for all your work! All look awesome.

Yes Label generations needs more work, I understand what you want to do.

One thing that I want to do is try to create a path to migrate from django-treebeard with their paths 0001.0002.0003 pattern, and I know it will need some refactor on the label to do so

@lunika
Copy link
Contributor

lunika commented Feb 17, 2025

Hi,

I'm looking for a django lib to use the ltree extension and I don't which one to choose between this one and django-ltree-2. Is it still a work in progress to merge both in the current project or are you diverging and the idea to have only one lib is no more something you are working on ?

Thanks

@mariocesar
Copy link
Owner

The ltree main is now merged with the latest from django-ltree-2. You can use it with a development install via pip. Currently, there is no new release for the merged project, as some tests and packaging work are still in progress.

@lunika
Copy link
Contributor

lunika commented Feb 17, 2025

Thank you.

So the new requirements of the ltree's main branch follow the one from ltree-2 ?

  • Python 3.9 to 3.13 supported.
  • PyPy 3.9 to 3.10 supported.
  • Django 4.2 to 5.1 supported.
  • Postgres 13 to 17 supported.

@mariocesar
Copy link
Owner

Yes, that is right

@baseplate-admin
Copy link
Contributor Author

baseplate-admin commented Feb 28, 2025

Hi, sorry for late response.

Python 3.9 to 3.13 supported.
PyPy 3.9 to 3.10 supported.
Django 4.2 to 5.1 supported.
Postgres 13 to 17 supported.

I recon it would work for other (older) versions too. These versions are actively tested in github-actions

Is it still a work in progress to merge both in the current project or are you diverging and the idea to have only one lib is no more something you are working on ?

Yep, most of the changes are merged in mainline django-ltree, the only change is that, django-ltree-2 does automatic label generation. That means if you use django-ltree-2 and then switch back to django-ltree, you might have to tweak the LABEL_SIZE in django-ltree

Thank you for your interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants