[Issue] Apply correct file permissions after renaming

[m2-assistant]

This issue is automatically created based on existing pull request: #39633: Apply correct file permissions after renaming

---

Preconditions (*)

Magento version : 2.4.2 or greater

Description (*)

Determine if the new path is a file and if so apply the correct file permissions after renaming so that files don't receive execute permissions.

Manual testing scenarios (*)

1. Upload an image via edit product, edit category or pagebuilder in the admin.

Expected Result

Uploaded image should have correct file permissions e.g. umask 022 -> 0644

Actual Result

Uploaded image has incorrect file permissions e.g. umask 022 -> 0755

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @philpage1983,

Thanks for the report and collaboration!

We have tried to reproduce the issue via uploading image from the category page:

Initially without the PR changes the file permission is as follows:

Array
(
    [file_permission] => 0775
    [umask] => 22
)

but after the PR changes the file permissions are as follows:

Array
(
    [file_permission] => 0664
    [umask] => 22
)

But as per the below text mentioned in the main description, the issue is reproducible while renaming:

Determine if the new path is a file and if so apply the correct file permissions after renaming so that files don't receive execute permissions.

Please elaborate on the renaming part in the context of the issue.

Thanks

[philpage1983]

@engcom-Hotel Apologies I just meant renaming in the context of it's the rename function that's affected.
The description should probably read:
When executing the rename function within the local filesystem driver, incorrect file permissions are assigned. This pull request updates the rename function to verify whether the newPath is a file and apply the appropriate permissions accordingly.

[engcom-Hotel]

Thank you for the clarification @philpage1983!

We are now confirming this issue for further processing.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-14013 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.