Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional allowed attribute #885

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

brosenberger
Copy link

@brosenberger brosenberger commented Jan 23, 2025

data-background-lazy-load is automatically added in pagebuilder for a text element, but is not allowed and leads to a warning message when saving e.g. an attribute text, therefore whitelist this additional attribute

Description (*)

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento/magento2-page-builder#<issue_number>: Issue title

Builds

Related Pull Requests

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] add additional allowed attribute #889: add additional allowed attribute

data-background-lazy-load is automatically added in pagebuilder for a text element, but is not allowed and leads to a warning message when saving e.g. an attribute text, therefore whitelist this additional attribute
@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review February 18, 2025 04:18
@engcom-Hotel
Copy link
Collaborator

@magento create issue

Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @brosenberger,

Thank you for the contribution!

Could you provide "Manual testing scenarios" or "Steps to reproduce" the original issue.

This will help us proceed further with the review and processing of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Changes Requested
Development

Successfully merging this pull request may close these issues.

[Issue] add additional allowed attribute
3 participants