Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble fiducial pose #40

Merged
merged 64 commits into from
Jul 26, 2024

Conversation

ChandimaFernando
Copy link
Collaborator

This PR constructs a pose_service node that listens to the rgb camera topic and uses ArUco fiducial markers to get the pose of the sample holder. Pose of the sample holder and a pick up point in front of the sample holder are then added to tf server.

tf_sample_holder

Copy link
Owner

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work!

I have some thoughts about naming of things, and thing a refactor on the use of "service" is in order. Some other small notes and scrubbing. But otherwise, this is really get.

@ChandimaFernando
Copy link
Collaborator Author

This is really great work!

I have some thoughts about naming of things, and thing a refactor on the use of "service" is in order. Some other small notes and scrubbing. But otherwise, this is really get.

In addition this PR contains fixes

  1. when ur_moveit.launch.py is launched, it looks for a missing file. Missing file added
  2. Two new ros nodes to open and close the gripper is added.
  3. new robot calibration parameters added
  4. devcontainer base package changed from humble-dev to humble-full :
    FROM althack/ros2:humble-full

Copy link
Owner

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work, needs a few changes that have been added in line, and some that I couldn't do in-line.

@maffettone maffettone merged commit 86764da into maffettone:humble Jul 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants