-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humble fiducial pose #40
Humble fiducial pose #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great work!
I have some thoughts about naming of things, and thing a refactor on the use of "service" is in order. Some other small notes and scrubbing. But otherwise, this is really get.
In addition this PR contains fixes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work, needs a few changes that have been added in line, and some that I couldn't do in-line.
This PR constructs a pose_service node that listens to the rgb camera topic and uses ArUco fiducial markers to get the pose of the sample holder. Pose of the sample holder and a pick up point in front of the sample holder are then added to tf server.