Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humble hande control #28

Merged
merged 32 commits into from
Mar 28, 2024

Conversation

ChandimaFernando
Copy link
Collaborator

@ChandimaFernando ChandimaFernando commented Mar 20, 2024

This PR adds a service call the hande gripper functionality. This creates a separate docker image to install gripper control libraries and start up a service to accept gripper control commands.

Note that the underlined gripper control functions are from PickNik:
PickNikRobotics/ros2_robotiq_gripper/tree/cmake-external-project-serial
It seems that the ros2_robotiq_gripper project has had advances recently, and their latest version can be found at: https://github.com/PickNikRobotics/ros2_robotiq_gripper .

Although, this work includes a binary build of the ros2_robotiq_gripper, the binary build is not being released to the humble apt-get repository.
(TODO @ChandimaFernando, check if this binary can be integrated to the package pdf_beamline so that the intermediary docker image can be removed in the future. Right now, we want to separate the pdf_beamtime from gripper controls as gripper control depends on libraries which, at present, are not being actively maintained by PickNik)

Note: This code is yet to be tested on hande gripper hardware.

Copy link
Owner

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Be judicious about:

  • Sleeping as a hack for conditionality/awaiting
  • Making redundant docker images

Will need to address the build with vcs import (setup.sh) to pass CI/CD.

@ChandimaFernando ChandimaFernando marked this pull request as ready for review March 26, 2024 16:15
Copy link
Owner

@maffettone maffettone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus some container questions.

  1. If we only need 1 image, then the necessary images should be deleted. We can do this in a future PR, but there's an extra image in this PR that we may not need.
  2. Let's try and use the build.sh and setup.sh files in the builds for those images.

doc: Some lint and readme additions
@maffettone maffettone merged commit fec4e2c into maffettone:humble Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants