generated from athackst/vscode_ros2_workspace
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humble hande control #28
Merged
maffettone
merged 32 commits into
maffettone:humble
from
ChandimaFernando:humble_hande_control
Mar 28, 2024
Merged
Humble hande control #28
maffettone
merged 32 commits into
maffettone:humble
from
ChandimaFernando:humble_hande_control
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffettone
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Be judicious about:
- Sleeping as a hack for conditionality/awaiting
- Making redundant docker images
Will need to address the build with vcs import (setup.sh
) to pass CI/CD.
maffettone
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good minus some container questions.
- If we only need 1 image, then the necessary images should be deleted. We can do this in a future PR, but there's an extra image in this PR that we may not need.
- Let's try and use the build.sh and setup.sh files in the builds for those images.
4946f86
to
efc9bf6
Compare
maffettone
reviewed
Mar 28, 2024
maffettone
reviewed
Mar 28, 2024
maffettone
reviewed
Mar 28, 2024
maffettone
reviewed
Mar 28, 2024
doc: Some lint and readme additions
maffettone
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a service call the hande gripper functionality. This creates a separate docker image to install gripper control libraries and start up a service to accept gripper control commands.
Note that the underlined gripper control functions are from PickNik:
PickNikRobotics/ros2_robotiq_gripper/tree/cmake-external-project-serial
It seems that the ros2_robotiq_gripper project has had advances recently, and their latest version can be found at: https://github.com/PickNikRobotics/ros2_robotiq_gripper .
Although, this work includes a binary build of the ros2_robotiq_gripper, the binary build is not being released to the humble apt-get repository.
(TODO @ChandimaFernando, check if this binary can be integrated to the package pdf_beamline so that the intermediary docker image can be removed in the future. Right now, we want to separate the pdf_beamtime from gripper controls as gripper control depends on libraries which, at present, are not being actively maintained by PickNik)
Note: This code is yet to be tested on hande gripper hardware.