Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessing functions should leave additional columns untouched and potentially support magnetometers directly #51

Open
AKuederle opened this issue Sep 8, 2023 · 0 comments · May be fixed by #73

Comments

@AKuederle
Copy link
Member

At the moment preprocessing functions for rotation and coordinate transformation only rotate acc and gyr data.

All other columns are actually removed from the dataset. While we don't have any algorithms that support anything besides acc and gyr data at the moment, it would be nice to allow users that have additional columns (i.e. mag or baro) to use the pre-processing functions without any additional work.

In particular the magnetometer would require special attention, as we would need to define a sensor and a body frame for it and explicitly rotate it as part of the respective functions.

This was first suggested in #50

@AKuederle AKuederle linked a pull request Feb 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant