Enacted ISF incorrect when 15 or greater when using mmol

[aidanlane]

Hi team,

Enacted ISF incorrect when 15 or greater when using mmol. See screenshot.
Could it be Trio providing the wrong information?
Anyway to debug that?

Trio 0.2.3 / LoopFollow 0.2.10 / Nightscout Pro

Have noticed this even with LoopFollow 0.2.8, but forgot to raise it earlier.

Thanks!

[aidanlane]

Just to be abundantly clear, we’re seeing this:
Autosense: 80%
ISF: 12.5 -> 0.9

However, we were expecting this:
Autosense: 80%
ISF: 12.5 -> 15.6

Cheers!

[aidanlane]

More examples, above and below 85%

[aidanlane]

Bug appears to be caused by the assumption made here that the determined ISF value should be treated as mmol if and only if the enacted ISF value is below 15. Hence, the determined ISF is incorrect when 15 or greater when using mmol.

LoopFollow/LoopFollow/Controllers/Nightscout/DeviceStatusOpenAPS.swift

Line 50 in bdf5e77

if enactedISFValue < 15 {

[aidanlane]

Btw, I've also noticed an assumption in the target, however I don't think that would ever be problematic:

LoopFollow/LoopFollow/Controllers/Nightscout/DeviceStatusOpenAPS.swift

Line 138 in bdf5e77

if enactedTargetValue < 40 {

[aidanlane]

Instead of trying to determine the units based on the value, shouldn’t it use the units from the profile?

[aidanlane]

Actually, I've noticed that enactedOrSuggested, which comes from OpenAPS (Trio in this case), always, for us at least, provides it's data in mg/L. Is that always the case with the OpenAPS protocol? Trio only?

[aidanlane]

Using my own hacky patch that assumes the data is in mg/L:

[bjorkert]

Hi, thanks for reporting. I will look into it.

[aidanlane]

Thank you!