Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIRGen support for __builtin_tan #1354

Open
FantasqueX opened this issue Feb 15, 2025 · 5 comments
Open

CIRGen support for __builtin_tan #1354

FantasqueX opened this issue Feb 15, 2025 · 5 comments
Labels
waiting4rebase

Comments

@FantasqueX
Copy link
Contributor

This is similar to #383
However, there is no TanOp in MLIR LLVM Dialect. Upstream PR llvm/llvm-project#125748 resolves this issue. After this PR being merged, CIRGen can be implemented easily.
@shrikardongre
Copy link

shrikardongre commented Feb 17, 2025 •
edited
Loading

hey ! @FantasqueX I see the PR you mentioned as already merged.
If thats the case i would really love to make my first contribution here if you dont have any problem :)

@FantasqueX
Copy link
Contributor Author

Hi @shrikardongre The problem is that this feature hasn't been merged into clangir code base. A rebase is needed.

@bcardosolopes
Copy link
Member

Ok, created a label to track things blocked on rebases

@bcardosolopes
Copy link
Member

@FantasqueX good job with the LLVM dialect fixes, if there are more issues like this one, feel free to start tagging around

@shrikardongre
Copy link

Do i have the correct permission to rebase it first and then work on implementing CIRGen for TanOp. Let me know if there’s anything specific I should keep in mind. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting4rebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bcardosolopes @FantasqueX @shrikardongre