Skip to content

Commit 3d53db9

Browse files
francispravin5igaw
authored andcommitted
nvme: remove double free in persistent-event-log
The pevent_collected structure uses the buffer address which is allocated using nvme_alloc_huge(). So, pevent_collected and mh.p has same address. Hence, remove _cleanup_free_ from pevent_collected to prevent double free. Signed-off-by: Francis Pravin <francis.p@samsung.com> Signed-off-by: Sathyavathi M <sathya.m@samsung.com>
1 parent 7a35395 commit 3d53db9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

nvme.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1475,8 +1475,8 @@ static int get_persistent_event_log(int argc, char **argv,
14751475
"processing this persistent log page command.";
14761476
const char *log_len = "number of bytes to retrieve";
14771477

1478-
_cleanup_free_ struct nvme_persistent_event_log *pevent_collected = NULL;
14791478
_cleanup_free_ struct nvme_persistent_event_log *pevent = NULL;
1479+
struct nvme_persistent_event_log *pevent_collected = NULL;
14801480
_cleanup_huge_ struct nvme_mem_huge mh = { 0, };
14811481
_cleanup_nvme_dev_ struct nvme_dev *dev = NULL;
14821482
enum nvme_print_flags flags;

0 commit comments

Comments
 (0)