Skip to content

Commit 14d0935

Browse files
hmi-jeonigaw
authored andcommitted
plugins/fdp: bugfix error check to validate output format
The return value of validate_output_format functions is whether the functions fails. So I fix to check the err variable. Signed-off-by: Minsik Jeon <hmi.jeon@samsung.com>
1 parent ecb51ed commit 14d0935

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

plugins/fdp/fdp.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ static int fdp_configs(int argc, char **argv, struct command *cmd,
5757
return err;
5858

5959
err = validate_output_format(cfg.output_format, &flags);
60-
if (flags < 0)
60+
if (err < 0)
6161
goto out;
6262

6363
if (cfg.raw_binary)
@@ -138,7 +138,7 @@ static int fdp_usage(int argc, char **argv, struct command *cmd, struct plugin *
138138
return err;
139139

140140
err = validate_output_format(cfg.output_format, &flags);
141-
if (flags < 0)
141+
if (err < 0)
142142
goto out;
143143

144144
if (cfg.raw_binary)
@@ -209,7 +209,7 @@ static int fdp_stats(int argc, char **argv, struct command *cmd, struct plugin *
209209
return err;
210210

211211
err = validate_output_format(cfg.output_format, &flags);
212-
if (flags < 0)
212+
if (err < 0)
213213
goto out;
214214

215215
if (cfg.raw_binary)
@@ -270,7 +270,7 @@ static int fdp_events(int argc, char **argv, struct command *cmd, struct plugin
270270
return err;
271271

272272
err = validate_output_format(cfg.output_format, &flags);
273-
if (flags < 0)
273+
if (err < 0)
274274
goto out;
275275

276276
if (cfg.raw_binary)
@@ -329,7 +329,7 @@ static int fdp_status(int argc, char **argv, struct command *cmd, struct plugin
329329
return err;
330330

331331
err = validate_output_format(cfg.output_format, &flags);
332-
if (flags < 0)
332+
if (err < 0)
333333
goto out;
334334

335335
if (cfg.raw_binary)

0 commit comments

Comments
 (0)