Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe emit transfer events inside of _transferShares() #422

Open
arwer13 opened this issue May 18, 2022 · 1 comment
Open

Maybe emit transfer events inside of _transferShares() #422

arwer13 opened this issue May 18, 2022 · 1 comment
Labels
next upgrade Things to pickup for the next protocol upgrade question Further information is requested

Comments

@arwer13
Copy link
Contributor

arwer13 commented May 18, 2022

Based on this comment

The starting idea was just to move emitting Transfer and TransferShares events into _transferShares function to reduce code duplication.

But doing so also requires significant changes at least in distributeRewards function, which is a subject for further investigation.

Here is a sketch of the scope of the changes requried: #421
@arwer13 arwer13 mentioned this issue May 18, 2022
Merged
@TheDZhon TheDZhon added the next upgrade Things to pickup for the next protocol upgrade label May 19, 2022
@tamtamchik tamtamchik added question Further information is requested and removed discussion labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next upgrade Things to pickup for the next protocol upgrade question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tamtamchik @TheDZhon @arwer13 and others