New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max size restriction applied to whole message not just data #11

Open

alanshaw opened this issue Apr 25, 2019 · 0 comments

Member

alanshaw commented Apr 25, 2019

For incoming messages the max size restriction is applied to the whole message, not just the data field:

https://github.com/libp2p/pull-mplex/blob/master/src/mplex.js#L84-L93

The spec says that the data field can be up to 1MB so this will be causing false positives for certain message sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment