Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow dots '.' in Identifier #162

Open
sapols opened this issue Oct 29, 2020 · 0 comments
Open

Don't allow dots '.' in Identifier #162

sapols opened this issue Oct 29, 2020 · 0 comments

Comments

@sapols
Copy link
Contributor

sapols commented Oct 29, 2020

We decided in #156 to temporarily allow dots '.' in Identifier to avoid solving namespacing issues. We need to disallow dots again.

The main sticking point is DataType.flatten where we're prepending parent Tuple names to Scalar IDs. We'll have to come up with a different way to keep track of parent Tuples—perhaps a metadata property that stores the dot-separated names.

Then there are other places like DataType.findAllVariables and DataType.getPath that perform special logic using the dot-separated IDs. We'll have to refactor those places to use whatever new construct we come up with.

There are TODOs in the code reminding us what places need to be changed once Identifier disallows dots again. Check:

  • identifier.scala
  • IdentifierSpec.scala
  • parsers.scala (specifically, def identifier)
  • ConstraintParserProps.scala (specifically, val identifier)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant