Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Dap2Service to use UnaryOperation.makeOperation #151

Open
dlindhol opened this issue Sep 17, 2020 · 1 comment
Open

Modify Dap2Service to use UnaryOperation.makeOperation #151

dlindhol opened this issue Sep 17, 2020 · 1 comment

Comments

@dlindhol
Copy link
Member

UnaryOperation.makeOperation is currently the single place to define mapping from operation expressions (initially for FDML processing instructions). The DAP2 service interface uses the same operation syntax so we should be able to reuse UnaryOperation.makeOperation.

@RyanJHeld
Copy link
Contributor

I just want to point out that UnaryOperation.makeOperation takes name: String and args: List[String] as input, meaning the expression (a string) has already been parsed into these components. Right now, FdmlParser.parseExpression turns a string expression into a CExpr and FdmlReader.makeOperation opens it up and passes name and args to UnaryOperation.makeOperation.

@lindholc lindholc changed the title Modify Dap2Service to us UnaryOperation.makeOperation Modify Dap2Service to use UnaryOperation.makeOperation Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants