New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vectorize support to AstraDBGraphVectorStore #98

Merged

epinzur merged 10 commits into main from graph_vectorize

Oct 25, 2024

Collaborator

epinzur commented Oct 22, 2024

No description provided.

epinzur added 4 commits

October 21, 2024 16:09


          progress on graph vectorize

ff8a782


          about to remove by_vector tests

1d4e677


          now only mmr failing

e52b272


          changes for mmr

f220236

epinzur added the do_not_merge label

epinzur added 3 commits

October 22, 2024 13:43


          lint

50dd530


          combined tests


          minor tweaks

4393c7f

epinzur force-pushed the graph_vectorize branch 2 times, most recently from 55f6e4f to 3febf29 Compare

October 23, 2024 08:22


          simiplify method in vectorstore

76edf89

epinzur force-pushed the graph_vectorize branch from 3febf29 to 76edf89 Compare

October 23, 2024 09:23

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/graph_vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/vectorstores.py Outdated Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/vectorstores.py Outdated Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/vectorstores.py Outdated Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/vectorstores.py Outdated Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/vectorstores.py Outdated Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/vectorstores.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/langchain_astradb/vectorstores.py Outdated Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/tests/integration_tests/conftest.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/tests/integration_tests/test_graphvectorstore.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/tests/integration_tests/test_vectorstore.py Show resolved Hide resolved

epinzur commented

View reviewed changes

libs/astradb/tests/integration_tests/test_vectorstore.py Show resolved Hide resolved

epinzur changed the title ~~WIP: Add Vectorize support to AstraDBGraphVectorStore~~ Add Vectorize support to AstraDBGraphVectorStore

epinzur removed the do_not_merge label

epinzur requested review from hemidactylus and kerinin

October 23, 2024 10:05


          shortcut return

9dcc670

epinzur force-pushed the graph_vectorize branch from 3f90f19 to 9dcc670 Compare

October 23, 2024 14:34

hemidactylus reviewed

View reviewed changes

libs/astradb/tests/integration_tests/test_graphvectorstore.py Show resolved Hide resolved


          split search_with_embedding method and added sync version

a46fec9

epinzur force-pushed the graph_vectorize branch from c927282 to a46fec9 Compare

October 24, 2024 11:11

epinzur requested a review from hemidactylus

October 24, 2024 12:59

epinzur mentioned this pull request

Create 'real' synchronous methods for GVS #100

Merged

hemidactylus approved these changes

View reviewed changes

Collaborator

hemidactylus left a comment

LGTM, thank you for your attention to everything!

epinzur merged commit 9f0ca93 into main

13 checks passed

epinzur deleted the graph_vectorize branch

October 25, 2024 09:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet