Improve GVS and VS pydoc #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
commented
Oct 8, 2024
| @@ -44,28 +49,144 @@ def _tag_to_str(kind: str, tag: str) -> str: | |||
| class AstraDBGraphVectorStore(GraphVectorStore): | |||
| def __init__( | |||
| self, | |||
| *, | |||
There was a problem hiding this comment.
This aligns with the vector store.
Breaking change but I believe it's not too late ?
WDYT @kerinin @hemidactylus ?
There was a problem hiding this comment.
Seems OK to me - IIUC this means that keyword arguments used positionally could be broken?
There was a problem hiding this comment.
IIUC this means that keyword arguments used positionally could be broken?
Yes, exactly.
There was a problem hiding this comment.
I agree: no big deal. A well-placed * can go a long way in preventing future headaches in these constructor signatures.
(also the general LC vibe is that "graph stuff is still sort-of-beta / expect the API to change", so even less trouble with the slight change here)
hemidactylus
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.