Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a benchmark for the trie #2059

Open
mpaulucci opened this issue Feb 24, 2025 · 1 comment · May be fixed by #2091
Open

Add a benchmark for the trie #2059

mpaulucci opened this issue Feb 24, 2025 · 1 comment · May be fixed by #2091
Labels
L1 Ethereum client performance

Comments

@mpaulucci
Copy link
Collaborator

Let's benchmark it comparing it with cita trie

We could mimic these benchmarks: https://github.com/citahub/cita_trie/blob/master/benches/trie.rs

We're already using cita to compare tests.
@mpaulucci mpaulucci added L1 Ethereum client performance labels Feb 24, 2025
@lakshya-sky lakshya-sky linked a pull request Feb 26, 2025 that will close this issue
Open
@lakshya-sky
Copy link

I've raised #2091 for this issue. during adding benchmark I found that remove on ethrex-trie was taking ownership of key but passing ref for creating nibble, so the ownership was unnecessary. I've changed the signature to use ref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L1 Ethereum client performance
Projects
ethrex_l1
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(l1): update trie remove fn signature and add bench lakshya-sky/ethrex
2 participants
@mpaulucci @lakshya-sky