Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L2, L1: Refactor ethrex.rs's logic to have a launcher for L1 and another for L2 #1987

Open
ilitteri opened this issue Feb 18, 2025 · 0 comments · May be fixed by #2064
Open

L2, L1: Refactor ethrex.rs's logic to have a launcher for L1 and another for L2 #1987

ilitteri opened this issue Feb 18, 2025 · 0 comments · May be fixed by #2064
Assignees
@tomip01
Labels
L1 Ethereum client L2 Rollup client

Comments

@ilitteri
Copy link
Contributor

To have a cleaner code it'd be good to separate the L1 and L2 launch logic even if we have to duplicate some code. Having ethrex.rs's main functions as follows would be very nice:

#[tokio::main]
async fn main() {
    let matches = cli::cli().get_matches();
    cfg_if::cfg_if! {
        if #[cfg(feature = "l2")] {
            launch_l2(...)
        } else {
            launch_l1(...)
        }
    }
}

...
@ilitteri ilitteri added L1 Ethereum client L2 Rollup client labels Feb 18, 2025
@tomip01 tomip01 self-assigned this Feb 20, 2025
@tomip01 tomip01 linked a pull request Feb 24, 2025 that will close this issue
Open
@mpaulucci mpaulucci removed this from ethrex_l1 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomip01 tomip01

Labels
L1 Ethereum client L2 Rollup client
Projects
ethrex_l2
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(l1,l2): separate L1 and L2 launch logic lambdaclass/ethrex
2 participants
@ilitteri @tomip01