Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1: Think alternatives of having Blockchain inside of SyncManager #2063

Open
JereSalo opened this issue Feb 24, 2025 · 0 comments
Open

L1: Think alternatives of having Blockchain inside of SyncManager #2063

JereSalo opened this issue Feb 24, 2025 · 0 comments
Labels
L1 Ethereum client tech debt Refactors, cleanups, etc

Comments

@JereSalo
Copy link
Contributor

Just think if it is a good idea to keep our Blockchain struct inside of SyncManager as it is done right now or if we should take it out.
Cons:

  • Locks the syncer for accessing blockchain. (Because we use a Mutex)
    Pros:
  • Easy access to blockchain struct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L1 Ethereum client tech debt Refactors, cleanups, etc
Projects
ethrex_l1
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpaulucci @JereSalo