Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracking] Hive engine-withdrawals test suite #1586

Open
1 of 31 tasks
fkrause98 opened this issue Dec 30, 2024 · 0 comments
Open
1 of 31 tasks

[Tracking] Hive engine-withdrawals test suite #1586

fkrause98 opened this issue Dec 30, 2024 · 0 comments
Labels
ef-tests Hive tests, execution-spec-tests L1 Ethereum client

Comments

@fkrause98
Copy link
Contributor

fkrause98 commented Dec 30, 2024 •
edited
Loading 

make run-hive SIMULATION=ethereum/engine TEST_PATTERN="engine-withdrawals"
cat $(ls -t hive/workspace/logs/*-*.json | head -n1) | jq '.testCases[] | select(.summaryResult.pass == false) | .name'

Currently failing tests:

  • Empty Withdrawals #1605
  • Corrupted Block Hash Payload (INVALID) #1608
  • Sync after 2 blocks - Withdrawals on Block 1 - Single Withdrawal Account - No Transactions
  • Sync after 2 blocks - Withdrawals on Block 1 - Single Withdrawal Account
  • Sync after 2 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts - No Transactions
  • Sync after 2 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts
  • Sync after 128 blocks - Withdrawals on Block 2 - Multiple Withdrawal Accounts
  • Withdrawals Fork on Block 1 - 1 Block Re-Org
  • Withdrawals Fork On Genesis
  • Withdrawals Fork on Block 1 - 8 Block Re-Org NewPayload
  • Withdrawals Fork on Block 1 - 8 Block Re-Org, Sync
  • Withdrawals Fork on Block 8 - 10 Block Re-Org NewPayload
  • Withdrawals Fork on Block 8 - 10 Block Re-Org Sync
  • Withdrawals Fork on Canonical Block 8 / Side Block 7 - 10 Block Re-Org
  • Withdrawals Fork on Canonical Block 8 / Side Block 7 - 10 Block Re-Org Sync
  • Withdrawals Fork on Canonical Block 8 / Side Block 9 - 10 Block Re-Org
  • Withdrawals Fork on Canonical Block 8 / Side Block 9 - 10 Block Re-Org Sync
  • GetPayloadBodiesByRange
  • Withdrawals Fork on Block 1
  • GetPayloadBodies After Sync
  • GetPayloadBodiesByRange (Sidechain)
  • GetPayloadBodiesByRange (Empty Transactions/Withdrawals)
  • GetPayloadBodiesByHash
  • GetPayloadBodiesByHash (Empty Transactions/Withdrawals)
  • GetPayloadBodies Parallel
  • Withdrawals Fork on Block 2
  • Withdrawals Fork on Block 3
  • Withdraw to a single account
  • Withdraw to two accounts
  • Withdraw many accounts
  • Withdraw zero amount
@fkrause98 fkrause98 changed the title [Tracking] Hive engine-withdrawals [Tracking] Hive engine-withdrawals test suite Dec 30, 2024
@mpaulucci mpaulucci pinned this issue Jan 2, 2025
@mpaulucci mpaulucci added L1 Ethereum client ef-tests Hive tests, execution-spec-tests labels Jan 9, 2025
@JulianVentura JulianVentura mentioned this issue Jan 14, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@JulianVentura
fix(l1): fixes some withdrawals hive tests (#1713)
e8a402a 
**Motivation**

There are some hive tests under `ethereum/engine` simulation that are
failing due to some mismatches between the implementation of some engine
RPC endpoints and their specification.

**Description**

This PR modifies some engine RPC endpoints validations, to comply with
[shangai](https://github.com/ethereum/execution-apis/blob/main/src/engine/shanghai.md)
and
[cancun](https://github.com/ethereum/execution-apis/blob/main/src/engine/cancun.md)
official ethereum engine specification. Those endpoints are:

* `engine_newPayloadV1`, `engine_newPayloadV2`, `engine_newPayloadV3`
* `engine_forkChoiceUpdatedV1`, `engine_forkChoiceUpdatedV2`,
`engine_forkChoiceUpdatedV3`
* `engine_getPayloadV1`, `engine_getPayloadV2`, `engine_getPayloadV3`

This PR fixes some of the failing tests mentioned on #1586. Those tests
are:
* Withdrawals Fork on Block 2 (Paris) (ethrex)
* Withdrawals Fork on Block 3 (Paris) (ethrex)


If you want, you can run only those tests by using the following
command:
```bash
make run-hive SIMULATION=ethereum/engine TEST_PATTERN="engine-withdrawals/(Withdrawals Fork on Block 2|Withdrawals Fork on Block 3)"
```

---------

Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
@LeanSerra LeanSerra mentioned this issue Feb 19, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 25, 2025
@LeanSerra
fix(l1): support multiple rpc requests in a single request (#2006)
86b6bda 
**Motivation**

The hive tests from `engine-withdrawals` were failing with a panic
because we were asuming only a single RLPRequest could be received but
the test sent an array of requets

**Description**

Introduce a wrapper struct that contains a `Single` type for single
`RPCRequest` and `Multiple` for an array of requests, so serde can
deserialize into the correct one.
If we have an array of request we execute them sequentially. Then return
a json encoded array of responses.
The function `rpc_response` was also changed to return
`serde_json::Value` because it was returning an incorrect value when
using it to create the array of responses.

This PR fixes the following tests from `engine-withdrawals`:

- "Withdrawals Fork on Block 1 - 1 Block Re-Org"
- "Withdrawals Fork on Block 1 - 8 Block Re-Org NewPayload"
- "Withdrawals Fork on Block 8 - 10 Block Re-Org NewPayload"
- "Withdrawals Fork on Canonical Block 8 / Side Block 7 - 10 Block
Re-Org"
- "Withdrawals Fork on Canonical Block 8 / Side Block 9 - 10 Block
Re-Org"

Advances #1586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ef-tests Hive tests, execution-spec-tests L1 Ethereum client
Projects
ethrex_l1
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpaulucci @fkrause98