Skip to content

Commit 94f1115

Browse files
badai-nguyenkyoichi-sugahara
authored andcommitted
fix(ground_segmentation): missing default parameters ERROR (autowarefoundation#8538)
fix(ground_segmentation): remove unused params Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
1 parent 8170346 commit 94f1115

File tree

2 files changed

+12
-21
lines changed

2 files changed

+12
-21
lines changed

perception/autoware_ground_segmentation/config/ground_segmentation.param.yaml

-15
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,5 @@
11
/**:
22
ros__parameters:
3-
additional_lidars: []
4-
ransac_input_topics: []
5-
use_single_frame_filter: False
6-
use_time_series_filter: True
7-
8-
common_crop_box_filter:
9-
parameters:
10-
min_x: -50.0
11-
max_x: 100.0
12-
min_y: -50.0
13-
max_y: 50.0
14-
max_z: 2.5 # recommended 2.5 for non elevation_grid_mode
15-
min_z: -2.5 # recommended 0.0 for non elevation_grid_mode
16-
negative: False
17-
183
common_ground_filter:
194
plugin: "autoware::ground_segmentation::ScanGroundFilterComponent"
205
parameters:

perception/autoware_ground_segmentation/launch/scan_ground_filter.launch.py

+12-6
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,15 @@ def launch_setup(context, *args, **kwargs):
3333
with open(vehicle_info_param_path, "r") as f:
3434
vehicle_info_param = yaml.safe_load(f)["/**"]["ros__parameters"]
3535

36+
ground_segmentation_param_path = os.path.join(
37+
get_package_share_directory("autoware_ground_segmentation"),
38+
"config",
39+
"ground_segmentation.param.yaml",
40+
)
41+
42+
with open(ground_segmentation_param_path, "r") as f:
43+
ground_segmentation_param = yaml.safe_load(f)["/**"]["ros__parameters"]
44+
3645
nodes = [
3746
ComposableNode(
3847
package="autoware_ground_segmentation",
@@ -43,12 +52,9 @@ def launch_setup(context, *args, **kwargs):
4352
("output", LaunchConfiguration("output/pointcloud")),
4453
],
4554
parameters=[
46-
{
47-
"global_slope_max_angle_deg": 10.0,
48-
"local_slope_max_angle_deg": 30.0,
49-
"split_points_distance_tolerance": 0.2,
50-
"split_height_distance": 0.2,
51-
},
55+
ground_segmentation_param["common_ground_filter"]["parameters"],
56+
{"input_frame": "base_link"},
57+
{"output_frame": "base_link"},
5258
vehicle_info_param,
5359
],
5460
),

0 commit comments

Comments
 (0)