-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Om oss/About us" a clickable button #34
Comments
It was an intentional choice as the "About us" page would be too long to encapsulate enough about Kvarteret |
In my opinion, it would be more user-friendly, by clicking on the "Om oss", it takes the user to "https://kvarteret.no/om-kvarteret" or "https://kvarteret.no/en/om-kvarteret" if the site is in english. |
I can agree on that tbh, but then we need to make it more clear that "Om oss" / "About us" has a multimenu. A solution could be to add a caret to it since it has another menu? |
@TheAzack9 @Cengelsen I started on this and added an icon. I can not change the actual CMS linkage for the Om oss nav-item as I don´t have permissions to it. But it should just be to change the href to /om-oss if you have the om oss page up and running, and the same for the english version. Check out the pull request in branch: eirik/om-oss-caret Also I don´t know what's going on with the yarn.lock file, but I think those are auto generated so it shouldn't be an issue to merge. |
"Om oss / About us" should take the user to the about page for Kvarteret when clicked on. Currently it just opens all the alternatives when hovering over the button.
It would be better if it could take the user to the standard "about"-page, in addition to showing all alternatives when hovering over it.
The text was updated successfully, but these errors were encountered: