AWS Provider incorrectly makes all alias records RecordTypeA

[jtszalay]

What happened:

I have a AAAA alias record. The AWS provider translates the record into an A record.

See:
https://github.com/kubernetes-sigs/external-dns/blob/master/provider/aws/aws.go#L1142
https://github.com/kubernetes-sigs/external-dns/blob/master/provider/aws/aws.go#L486
https://github.com/kubernetes-sigs/external-dns/blob/master/provider/aws/aws.go#L779

This results in my A and AAAA aliases with the same name colliding.

What you expected to happen:
I expect AAAA records to be treated as AAAA.

How to reproduce it (as minimally and precisely as possible):

I have a CRD with:

spec:
  endpoints:
    - dnsName: my.example.com
      labels:
        k8slens-edit-resource-version: v1
      providerSpecific:
        - name: aws/evaluate-target-health
          value: 'true'
        - name: alias
          value: 'true'
        - name: aws/region
          value: eu-west-2
        - name: aws/target-hosted-zone
          value: ZONEIDHERE
      recordType: AAAA
      setIdentifier: myid-1
      targets:
        - myother.example.com

This fails to create heritage record and the alias record.

Anything else we need to know?:

I found this somewhat related PR: #3605

Environment:

• External-DNS version (use external-dns --version): 0.15.0
• DNS provider: AWS
• Others: Source is CRD

[ivankatliarchuk]

Will be partially resolved when this fix is merged #4889

[ivankatliarchuk]

/help
/area provider/aws

[k8s-ci-robot]

@ivankatliarchuk:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/area provider/aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.