Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting DigitalOcean rate limit #4572

Open
tja opened this issue Jun 25, 2024 · 11 comments
Open

Allow setting DigitalOcean rate limit #4572

tja opened this issue Jun 25, 2024 · 11 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tja
Copy link

tja commented Jun 25, 2024

What would you like to be added:

Requests to the DigitalOcean API should be spaced out to avoid the current rate limit of 250 requests per minute.

Why is this needed:

I host many domains (and subdomains) at DigitalOcean, in the order of a few hundred. The external-dns DigitalOcean provider is hammering the DO API unthrottled, thus hitting their rate limits of 250 requests per minute, resulting in HTTP status code 429 and a crash of external-dns (and a crash loop as it tries over and over again).

While others have complained about this before, see #1429, the solution so far has been to increase the page count. Unfortunately this does not solve the problem for me.

@tja tja added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2024
@Routhinator
Copy link

Routhinator commented Jul 10, 2024

Additionally, this is not just effecting the longevity of the pod for me. This is happening in my home lab, and the result is the pod no only hammers the DO API, but it also triggers a ban from github API as it triggers a Cloudflare API ban and it takes affect across sites, and getting me banned from being able to pull code... It's been fun. I've resorted to shutting the pod down when I don't need a record to update, but that literally defeats the point of the service.

@Routhinator
Copy link

I think this needs to be renamed or a ticket needs to aggregate all the rate limit problems that external-dns is causing across multiple providers

#4532 for example is the same issue, different provider.

@tja
Copy link
Author

tja commented Jul 10, 2024

I think this needs to be renamed or a ticket needs to aggregate all the rate limit problems that external-dns is causing across multiple providers

#4532 for example is the same issue, different provider.

@Routhinator: Without a major refactoring, rate limiting will have to be done by each provider individually. But I would prefer to have at least one generic option/flag instead of littering the options with provider-prefixed flags.

@Routhinator
Copy link

But I would prefer to have at least one generic option/flag instead of littering the options with provider-prefixed flags.

This is the key for me, there are so many provider specific flags for generic config options common to multiple providers, and many are not documented outside their respective prs and that one issue where they've documented a list of undocumented flags.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2024
@Routhinator
Copy link

This is still very relevant.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 14, 2024
@Routhinator
Copy link

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2025
@Routhinator
Copy link

/remove-lifecycle rotten

@Routhinator
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants