-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting DigitalOcean rate limit #4572
Comments
Additionally, this is not just effecting the longevity of the pod for me. This is happening in my home lab, and the result is the pod no only hammers the DO API, but it also triggers a ban from github API as it triggers a Cloudflare API ban and it takes affect across sites, and getting me banned from being able to pull code... It's been fun. I've resorted to shutting the pod down when I don't need a record to update, but that literally defeats the point of the service. |
I think this needs to be renamed or a ticket needs to aggregate all the rate limit problems that external-dns is causing across multiple providers #4532 for example is the same issue, different provider. |
@Routhinator: Without a major refactoring, rate limiting will have to be done by each provider individually. But I would prefer to have at least one generic option/flag instead of littering the options with provider-prefixed flags. |
This is the key for me, there are so many provider specific flags for generic config options common to multiple providers, and many are not documented outside their respective prs and that one issue where they've documented a list of undocumented flags. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
This is still very relevant. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle rotten |
/remove-lifecycle stale |
What would you like to be added:
Requests to the DigitalOcean API should be spaced out to avoid the current rate limit of 250 requests per minute.
Why is this needed:
I host many domains (and subdomains) at DigitalOcean, in the order of a few hundred. The external-dns DigitalOcean provider is hammering the DO API unthrottled, thus hitting their rate limits of 250 requests per minute, resulting in HTTP status code
429
and a crash of external-dns (and a crash loop as it tries over and over again).While others have complained about this before, see #1429, the solution so far has been to increase the page count. Unfortunately this does not solve the problem for me.
The text was updated successfully, but these errors were encountered: