Cloudflare provider rate limits cause a fatal error and pod restarts into CLBO

[ebachle]

What happened: External DNS for Cloudflare often enters CrashLoopBackOff when it hits a rate limit. Since this was merged #3009 with the v0.13.5 release this has been occurring. We caught it on an upgrade to 0.14.1

What you expected to happen: Rate limit errors should be handled as the new SoftError type to prevent bailing and restarting.

How to reproduce it (as minimally and precisely as possible):

• Run a version of external-dns >= 0.13.5
• Use up the rate limit of Cloudflare API calls (or mock this)
• Have external-dns running through a loop
• It will then exit and bail.

Anything else we need to know?:

I'm willing to attempt to fix this, though my golang isn't super

Environment:

• External-DNS version (use external-dns --version): 0.14.1
• DNS provider: cloudflare
• Others:

[ariretiarno]

Hi, this issue still happened on my deployment

[ebachle]

While the change is merged, I don't think a release has been cut since then, so you'd have to build it from source to pick up the fix.

…

On Thu, Jun 6, 2024, 3:40 AM ariretiarno ***@***.***> wrote: Hi, this issue still happened on my deployment image.png (view on web) <https://github.com/kubernetes-sigs/external-dns/assets/46735686/fc4a1e60-529e-4f71-b2ba-e93529f3597f> image.png (view on web) <https://github.com/kubernetes-sigs/external-dns/assets/46735686/27c4fd60-cf43-4c1e-9dd9-35a325d7ea58> — Reply to this email directly, view it on GitHub <#4434 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATTHQWEWYVAWOEAWPJFR5TZGAG5PAVCNFSM6AAAAABHJQR5UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJRGYYDQOJWGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>