From 352cf68b6b7ba712cc0270d01b00777c34562cfb Mon Sep 17 00:00:00 2001 From: Ole Markus With Date: Wed, 7 Sep 2022 15:31:12 +0200 Subject: [PATCH] If one source fails, continue to the next source instead of bailing --- source/multisource.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source/multisource.go b/source/multisource.go index 9cba236637..bb746f299d 100644 --- a/source/multisource.go +++ b/source/multisource.go @@ -19,6 +19,7 @@ package source import ( "context" + log "github.com/sirupsen/logrus" "sigs.k8s.io/external-dns/endpoint" ) @@ -35,7 +36,8 @@ func (ms *multiSource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint, err for _, s := range ms.children { endpoints, err := s.Endpoints(ctx) if err != nil { - return nil, err + log.Errorf("failed to collect endpoints for source %T: %v", s, err) + continue } if len(ms.defaultTargets) > 0 { for i := range endpoints {