Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace exporter should pull osquery details from cached enrollment details instead of querying #2076

Open
RebeccaMahany opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@RebeccaMahany
Copy link
Contributor

RebeccaMahany commented Jan 29, 2025

Once #1986 is complete, we can update the trace exporter to remove osqueryClient entirely. Instead, addAttributesFromOsquery can wait for the enrollment details to be available via the knapsack.

We should check to see if the enrollment details are immediately available (i.e. they've already been cached), and if so, set them at the same time as we set addDeviceIdentifyingAttributes, to avoid having to re-create the exporter unnecessarily.

@cesarfda cesarfda self-assigned this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants