From d92f24c18c331ab745898eec5ac6284cfd4269df Mon Sep 17 00:00:00 2001
From: Thomas Padioleau <thomas.padioleau@cea.fr>
Date: Mon, 24 Feb 2025 20:24:14 +0100
Subject: [PATCH 1/3] Fix missing constexpr and device annotations for ctor

---
 include/experimental/__p0009_bits/layout_left.hpp  | 1 +
 include/experimental/__p0009_bits/layout_right.hpp | 1 +
 2 files changed, 2 insertions(+)

diff --git a/include/experimental/__p0009_bits/layout_left.hpp b/include/experimental/__p0009_bits/layout_left.hpp
index c6dc1d19..268a3906 100644
--- a/include/experimental/__p0009_bits/layout_left.hpp
+++ b/include/experimental/__p0009_bits/layout_left.hpp
@@ -132,6 +132,7 @@ class layout_left::mapping {
       )
     )
     MDSPAN_CONDITIONAL_EXPLICIT((!std::is_convertible_v<typename _Mapping::extents_type, extents_type>))
+    MDSPAN_INLINE_FUNCTION MDSPAN_IMPL_CONSTEXPR_14
     mapping(const _Mapping& __other) noexcept
       : __extents(__other.extents())
     {
diff --git a/include/experimental/__p0009_bits/layout_right.hpp b/include/experimental/__p0009_bits/layout_right.hpp
index 93de9f47..42d4198e 100644
--- a/include/experimental/__p0009_bits/layout_right.hpp
+++ b/include/experimental/__p0009_bits/layout_right.hpp
@@ -132,6 +132,7 @@ class layout_right::mapping {
         MDSPAN_IMPL_PROPOSED_NAMESPACE::detail::is_layout_right_padded_mapping<_Mapping>::value
         && std::is_constructible_v<extents_type, typename _Mapping::extents_type>))
     MDSPAN_CONDITIONAL_EXPLICIT((!std::is_convertible_v<typename _Mapping::extents_type, extents_type>))
+    MDSPAN_INLINE_FUNCTION MDSPAN_IMPL_CONSTEXPR_14
     mapping(const _Mapping &__other) noexcept
         : __extents(__other.extents())
     {

From 8fe01f53cd50ab3449e45ffdd612cf691fb52b3a Mon Sep 17 00:00:00 2001
From: Thomas Padioleau <thomas.padioleau@cea.fr>
Date: Wed, 26 Feb 2025 17:52:45 +0100
Subject: [PATCH 2/3] Update include/experimental/__p0009_bits/layout_left.hpp

Review of @dalg24

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
---
 include/experimental/__p0009_bits/layout_left.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/experimental/__p0009_bits/layout_left.hpp b/include/experimental/__p0009_bits/layout_left.hpp
index 268a3906..0248f586 100644
--- a/include/experimental/__p0009_bits/layout_left.hpp
+++ b/include/experimental/__p0009_bits/layout_left.hpp
@@ -132,7 +132,7 @@ class layout_left::mapping {
       )
     )
     MDSPAN_CONDITIONAL_EXPLICIT((!std::is_convertible_v<typename _Mapping::extents_type, extents_type>))
-    MDSPAN_INLINE_FUNCTION MDSPAN_IMPL_CONSTEXPR_14
+    MDSPAN_INLINE_FUNCTION constexpr
     mapping(const _Mapping& __other) noexcept
       : __extents(__other.extents())
     {

From 020c64f64d44b6a3600f917fdbdd6b8a59ee5971 Mon Sep 17 00:00:00 2001
From: Thomas Padioleau <thomas.padioleau@cea.fr>
Date: Wed, 26 Feb 2025 18:14:28 +0100
Subject: [PATCH 3/3] Review of @dalg24

---
 include/experimental/__p0009_bits/layout_right.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/experimental/__p0009_bits/layout_right.hpp b/include/experimental/__p0009_bits/layout_right.hpp
index 42d4198e..04f1b640 100644
--- a/include/experimental/__p0009_bits/layout_right.hpp
+++ b/include/experimental/__p0009_bits/layout_right.hpp
@@ -132,7 +132,7 @@ class layout_right::mapping {
         MDSPAN_IMPL_PROPOSED_NAMESPACE::detail::is_layout_right_padded_mapping<_Mapping>::value
         && std::is_constructible_v<extents_type, typename _Mapping::extents_type>))
     MDSPAN_CONDITIONAL_EXPLICIT((!std::is_convertible_v<typename _Mapping::extents_type, extents_type>))
-    MDSPAN_INLINE_FUNCTION MDSPAN_IMPL_CONSTEXPR_14
+    MDSPAN_INLINE_FUNCTION constexpr
     mapping(const _Mapping &__other) noexcept
         : __extents(__other.extents())
     {