Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fails on Windows due to "fred" dependency #603

Open
kartonrad opened this issue Oct 29, 2024 · 2 comments
Open

Compilation fails on Windows due to "fred" dependency #603

kartonrad opened this issue Oct 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kartonrad
Copy link

Describe the bug
Compilation fails:

error[E0432]: unresolved import `tokio::net::UnixStream`
  --> C:\Users\<user>\.cargo\registry\src\index.crates.io-6f17d22bba15001f\fred-9.3.0\src\protocol\connection.rs:65:5
   |
65 | use tokio::net::UnixStream;
   |     ^^^^^^^^^^^^^^^^^^^^^^ no `UnixStream` in `net`
   |
note: found an item that was configured out
  --> C:\Users\<user>\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.41.0\src\net\mod.rs:57:27
57 |     pub use unix::stream::UnixStream;
   |                           ^^^^^^^^^^
note: the item is gated here
  --> C:\Users\<user>\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.41.0\src\net\mod.rs:53:1
53 | / cfg_net_unix! {
54 | |     pub mod unix;
56 | |     pub use unix::listener::UnixListener;
57 | |     pub use unix::stream::UnixStream;
59 | | }
   | |_^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `fred` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

To Reproduce
Steps to reproduce the behavior:

  1. Clone repo on windows system
  2. rustup install nightly
  3. cargo build

Expected behavior
Compilation success or documented non-support.

Version
main branch as of today, 126d8b1

@kartonrad kartonrad added the bug Something isn't working label Oct 29, 2024
@kartonrad
Copy link
Author

cargo check succeeds under Wsl, and should work on any Unix System.

@aumetra
Copy link
Member

aumetra commented Oct 29, 2024

Will have a look, I think it's because we unconditionally enable the Unix socket feature. Gonna add a cfg gate in front of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants