From c1fdc5dc1b300e408b18f05257bb24250b03c266 Mon Sep 17 00:00:00 2001 From: Andreas Pfeil Date: Wed, 22 Jan 2025 00:36:47 +0100 Subject: [PATCH] feat: warn via logging if the cache size is unusual low. This is useful for deployment, but also to see in benchmarks if the parameter has been set properly. --- .../pit/configuration/ApplicationProperties.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/main/java/edu/kit/datamanager/pit/configuration/ApplicationProperties.java b/src/main/java/edu/kit/datamanager/pit/configuration/ApplicationProperties.java index 438a40bd..a9c422fa 100644 --- a/src/main/java/edu/kit/datamanager/pit/configuration/ApplicationProperties.java +++ b/src/main/java/edu/kit/datamanager/pit/configuration/ApplicationProperties.java @@ -29,6 +29,8 @@ import lombok.Getter; import lombok.Setter; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Value; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; @@ -50,6 +52,7 @@ @Configuration @Validated public class ApplicationProperties extends GenericApplicationProperties { + private static final Logger LOG = LoggerFactory.getLogger(ApplicationProperties.class); /** * Internal default set of types which indicate that, when used as a key @@ -189,7 +192,10 @@ public void setValidationStrategy(ValidationStrategy strategy) { } public int getCacheMaxEntries() { - return cacheMaxEntries; + if (this.cacheMaxEntries <= 10) { + LOG.warn("Cache max entries is set to {} (low value)", this.cacheMaxEntries); + } + return this.cacheMaxEntries; } public void setCacheMaxEntries(int cacheMaxEntries) {