do not need to check if element in dict input is Tensor. (pytorch#97866)

sometimes it's a tuple with tensor element such as past value key in text generation case

Fixes pytorch#97229

Pull Request resolved: pytorch#97866
Approved by: https://github.com/jgong5, https://github.com/davidberard98

Author: sywangyi

test/jit/test_tracer.py

@@ -1973,6 +1973,22 @@ def forward(self, x, y, **deprecated_arguments):
         m2 = torch.jit.trace(model, (torch.ones(1), torch.ones(1)))
         m3 = torch.jit.trace(model, example_kwarg_inputs={'x': torch.ones(1), "y": torch.ones(1)}, strict=False)
 
+    def test_trace_with_tuple_tensor(self):
+        class MyClass(torch.nn.Module):
+            def __init__(self):
+                super(MyClass, self).__init__()
+
+            def forward(self, x, y):
+                return x + y[0] + y[1]
+
+        model = MyClass()
+        traced_model = torch.jit.trace(model, (torch.ones(1), (torch.ones(1), torch.ones(1))))
+        input_dict = {"x": torch.tensor([2, 3]), "y": (torch.tensor([5, 6]), torch.tensor([7, 8]))}
+        self.assertEqual(model(**input_dict), traced_model(**input_dict))
+        traced_model = torch.jit.trace(model, example_kwarg_inputs={
+                                       'x': torch.ones(1), "y": (torch.ones(1), torch.ones(1))})
+        self.assertEqual(model(**input_dict), traced_model(**input_dict))
+
 
 class TestMixTracingScripting(JitTestCase):
     def test_trace_script(self):

torch/csrc/jit/python/python_tracer.cpp

@@ -102,10 +102,8 @@ std::pair<std::shared_ptr<Graph>, Stack> createGraphByTracingWithDict(
   for (const auto& compact_argument_name : compact_argument_names) {
     for (auto it = inputs_dict.begin(); it != inputs_dict.end(); it++) {
       if (py::cast<std::string>(it->first) == compact_argument_name) {
-        if (THPVariable_Check(it->second.ptr())) {
-          compact_trace_inputs.push_back(
-              toIValue(it->second, tryToInferType(it->second).type()));
-        }
+        compact_trace_inputs.push_back(
+            toIValue(it->second, tryToInferType(it->second).type()));
       }
     }
   }