[BE] Enable ruff's UP rules and autoformat tools and scripts (pytorch#105428)

Pull Request resolved: pytorch#105428
Approved by: https://github.com/albanD, https://github.com/soulitzer, https://github.com/malfet

Author: justinchuby

.ci/pytorch/create_test_cert.py

@@ -88,9 +88,9 @@ def sign_certificate_request(path, csr_cert, ca_cert, private_ca_key):
 
 
 ca_key = genrsa(temp_dir + "/ca.key")
-ca_cert = create_cert(temp_dir + "/ca.pem", u"US", u"New York", u"New York", u"Gloo Certificate Authority", ca_key)
+ca_cert = create_cert(temp_dir + "/ca.pem", "US", "New York", "New York", "Gloo Certificate Authority", ca_key)
 
 pkey = genrsa(temp_dir + "/pkey.key")
-csr = create_req(temp_dir + "/csr.csr", u"US", u"California", u"San Francisco", u"Gloo Testing Company", pkey)
+csr = create_req(temp_dir + "/csr.csr", "US", "California", "San Francisco", "Gloo Testing Company", pkey)
 
 cert = sign_certificate_request(temp_dir + "/cert.pem", csr, ca_cert, ca_key)

.ci/pytorch/perf_test/compare_with_baseline.py

@@ -19,7 +19,7 @@
 elif 'gpu' in test_name:
     backend = 'gpu'
 
-data_file_path = '../{}_runtime.json'.format(backend)
+data_file_path = f'../{backend}_runtime.json'
 
 with open(data_file_path) as data_file:
     data = json.load(data_file)
@@ -69,7 +69,7 @@
     print("z-value < 3, no perf regression detected.")
     if args.update:
         print("We will use these numbers as new baseline.")
-        new_data_file_path = '../new_{}_runtime.json'.format(backend)
+        new_data_file_path = f'../new_{backend}_runtime.json'
         with open(new_data_file_path) as new_data_file:
             new_data = json.load(new_data_file)
         new_data[test_name] = {}

.circleci/cimodel/data/binary_build_definitions.py

@@ -5,7 +5,7 @@
 import cimodel.lib.conf_tree as conf_tree
 import cimodel.lib.miniutils as miniutils
 
-class Conf(object):
+class Conf:
     def __init__(self, os, gpu_version, pydistro, parms, smoke, libtorch_variant, gcc_config_variant, libtorch_config_variant):
 
         self.os = os

.circleci/cimodel/data/pytorch_build_definitions.py

@@ -143,7 +143,7 @@ def gen_workflow_job(self, phase):
 
 
 # TODO This is a hack to special case some configs just for the workflow list
-class HiddenConf(object):
+class HiddenConf:
     def __init__(self, name, parent_build=None, filters=None):
         self.name = name
         self.parent_build = parent_build
@@ -160,7 +160,7 @@ def gen_workflow_job(self, phase):
     def gen_build_name(self, _):
         return self.name
 
-class DocPushConf(object):
+class DocPushConf:
     def __init__(self, name, parent_build=None, branch="master"):
         self.name = name
         self.parent_build = parent_build

.circleci/generate_config_yml.py

@@ -18,7 +18,7 @@
 import cimodel.lib.miniyaml as miniyaml
 
 
-class File(object):
+class File:
     """
     Verbatim copy the contents of a file into config.yml
     """
@@ -57,7 +57,7 @@ def horizontal_rule():
     return "".join("#" * 78)
 
 
-class Header(object):
+class Header:
     def __init__(self, title, summary=None):
         self.title = title
         self.summary_lines = summary or []

.github/scripts/ensure_actions_will_cancel.py

@@ -17,7 +17,7 @@
 
 
 def should_check(filename: Path) -> bool:
-    with open(filename, "r") as f:
+    with open(filename) as f:
         content = f.read()
 
     data = yaml.safe_load(content)
@@ -37,7 +37,7 @@ def should_check(filename: Path) -> bool:
     files = [f for f in files if should_check(f)]
     names = set()
     for filename in files:
-        with open(filename, "r") as f:
+        with open(filename) as f:
             data = yaml.safe_load(f)
 
         name = data.get("name")

.github/scripts/file_io_utils.py

@@ -44,7 +44,7 @@ def load_json_file(file_path: Path) -> Any:
     """
     Returns the deserialized json object
     """
-    with open(file_path, "r") as f:
+    with open(file_path) as f:
         return json.load(f)
 
 

.github/scripts/filter_test_configs.py

@@ -319,7 +319,7 @@ def process_jobs(
     try:
         # The job name from github is in the PLATFORM / JOB (CONFIG) format, so breaking
         # it into its two components first
-        current_platform, _ = [n.strip() for n in job_name.split(JOB_NAME_SEP, 1) if n]
+        current_platform, _ = (n.strip() for n in job_name.split(JOB_NAME_SEP, 1) if n)
     except ValueError as error:
         warnings.warn(f"Invalid job name {job_name}, returning")
         return test_matrix

.github/scripts/generate_pytorch_version.py

@@ -50,7 +50,7 @@ def get_tag() -> str:
 
 def get_base_version() -> str:
     root = get_pytorch_root()
-    dirty_version = open(root / "version.txt", "r").read().strip()
+    dirty_version = open(root / "version.txt").read().strip()
     # Strips trailing a0 from version.txt, not too sure why it's there in the
     # first place
     return re.sub(LEGACY_BASE_VERSION_SUFFIX_PATTERN, "", dirty_version)

.github/scripts/label_utils.py

@@ -51,7 +51,7 @@ def get_last_page_num_from_header(header: Any) -> int:
     )
 
 
-@lru_cache()
+@lru_cache
 def gh_get_labels(org: str, repo: str) -> List[str]:
     prefix = f"https://api.github.com/repos/{org}/{repo}/labels?per_page=100"
     header, info = request_for_labels(prefix + "&page=1")

.github/scripts/lint_native_functions.py

@@ -26,7 +26,7 @@ def fn(base: str) -> str:
     return str(base / Path("aten/src/ATen/native/native_functions.yaml"))
 
 
-with open(Path(__file__).parent.parent.parent / fn("."), "r") as f:
+with open(Path(__file__).parent.parent.parent / fn(".")) as f:
     contents = f.read()
 
 yaml = ruamel.yaml.YAML()  # type: ignore[attr-defined]

.github/scripts/run_torchbench.py

@@ -129,7 +129,7 @@ def extract_models_from_pr(
     model_list = []
     userbenchmark_list = []
     pr_list = []
-    with open(prbody_file, "r") as pf:
+    with open(prbody_file) as pf:
         lines = (x.strip() for x in pf.read().splitlines())
         magic_lines = list(filter(lambda x: x.startswith(MAGIC_PREFIX), lines))
         if magic_lines:
@@ -157,7 +157,7 @@ def extract_models_from_pr(
 
 def find_torchbench_branch(prbody_file: str) -> str:
     branch_name: str = ""
-    with open(prbody_file, "r") as pf:
+    with open(prbody_file) as pf:
         lines = (x.strip() for x in pf.read().splitlines())
         magic_lines = list(
             filter(lambda x: x.startswith(MAGIC_TORCHBENCH_PREFIX), lines)

.github/scripts/test_check_labels.py

@@ -15,7 +15,7 @@
 
 
 def mock_parse_args() -> object:
-    class Object(object):
+    class Object:
         def __init__(self) -> None:
             self.pr_num = 76123
 

.github/scripts/test_trymerge.py

@@ -114,7 +114,7 @@ def mocked_rockset_results(head_sha: str, merge_base: str, num_retries: int = 3)
 
 
 def mock_parse_args(revert: bool = False, force: bool = False) -> Any:
-    class Object(object):
+    class Object:
         def __init__(self) -> None:
             self.revert = revert
             self.force = force

.github/scripts/trymerge.py

@@ -1628,10 +1628,8 @@ def validate_revert(
         allowed_reverters.append("CONTRIBUTOR")
     if author_association not in allowed_reverters:
         raise PostCommentError(
-            (
-                f"Will not revert as @{author_login} is not one of "
-                f"[{', '.join(allowed_reverters)}], but instead is {author_association}."
-            )
+            f"Will not revert as @{author_login} is not one of "
+            f"[{', '.join(allowed_reverters)}], but instead is {author_association}."
         )
     skip_internal_checks = can_skip_internal_checks(pr, comment_id)
 

.github/scripts/trymerge_explainer.py

@@ -17,7 +17,7 @@ def has_label(labels: List[str], pattern: Pattern[str] = CIFLOW_LABEL) -> bool:
     return len(list(filter(pattern.match, labels))) > 0
 
 
-class TryMergeExplainer(object):
+class TryMergeExplainer:
     force: bool
     labels: List[str]
     pr_num: int

docs/caffe2/process.py

@@ -8,7 +8,7 @@
 
 # Module caffe2...caffe2.python.control_test
 def insert(originalfile, first_line, description):
-    with open(originalfile, 'r') as f:
+    with open(originalfile) as f:
         f1 = f.readline()
         if(f1.find(first_line) < 0):
             docs = first_line + description + f1
@@ -30,7 +30,7 @@ def insert(originalfile, first_line, description):
     for file in files:
         if (file.endswith(".py") and not file.endswith("_test.py") and not file.endswith("__.py")):
             filepath = os.path.join(root, file)
-            print(("filepath: " + filepath))
+            print("filepath: " + filepath)
             directory = os.path.dirname(filepath)[2:]
             directory = directory.replace("/", ".")
             print("directory: " + directory)

docs/cpp/source/conf.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 #
 # PyTorch documentation build configuration file, created by
 # sphinx-quickstart on Fri Dec 23 13:31:47 2016.
@@ -99,7 +98,7 @@
     ############################################################################
     # Main library page layout example configuration.                          #
     ############################################################################
-    "afterTitleDescription": textwrap.dedent(u'''
+    "afterTitleDescription": textwrap.dedent('''
         Welcome to the developer reference for the PyTorch C++ API.
     '''),
 }

docs/source/conf.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 #
 # PyTorch documentation build configuration file, created by
 # sphinx-quickstart on Fri Dec 23 13:31:47 2016.
@@ -624,7 +623,7 @@ def visit_reference(self, node):
                 anchor = ref_anchor[1]
                 txt = node.parent.astext()
                 if txt == anchor or txt == anchor.split('.')[-1]:
-                    self.body.append('<p id="{}"/>'.format(ref_anchor[1]))
+                    self.body.append(f'<p id="{ref_anchor[1]}"/>')
         return old_call(self, node)
     Klass.visit_reference = visit_reference
 

docs/source/scripts/exportdb/generate_example_rst.py

@@ -31,7 +31,7 @@ def generate_example_rst(example_case: ExportCase):
         if isinstance(model, torch.nn.Module)
         else inspect.getfile(model)
     )
-    with open(source_file, "r") as file:
+    with open(source_file) as file:
         source_code = file.read()
     source_code = re.sub(r"from torch\._export\.db\.case import .*\n", "", source_code)
     source_code = re.sub(r"@export_case\((.|\n)*?\)\n", "", source_code)
@@ -114,7 +114,7 @@ def generate_index_rst(example_cases, tag_to_modules, support_level_to_modules):
 
     tag_names = "\n    ".join(t for t in tag_to_modules.keys())
 
-    with open(os.path.join(PWD, "blurb.txt"), "r") as file:
+    with open(os.path.join(PWD, "blurb.txt")) as file:
         blurb = file.read()
 
     # Generate contents of the .rst file