Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store action in SchreierTransversal #43

Merged
merged 12 commits into from
Apr 23, 2024
Merged

Conversation

kalmarek
Copy link
Owner

@kalmarek kalmarek commented Apr 18, 2024

  • fix some printing issues
  • parametrize SchreierTransversal by the type of action so that it is possible to reconstruct representatives even when op ≠ ^ (i.e. G acts on itself via *)
  • use randomized shallowing of Schreier trees (direct-product benchmark is now 3×faster)
  • update benchmarks timings to new cpu

This is in preparation of kalmarek/SymbolicWedderburn.jl#69

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (e9393ec) to head (68fb486).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   96.42%   97.48%   +1.05%     
==========================================
  Files          11       11              
  Lines         615      635      +20     
==========================================
+ Hits          593      619      +26     
+ Misses         22       16       -6     
Flag Coverage Δ
unittests 97.48% <100.00%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalmarek kalmarek force-pushed the mk/SchreierTransversal_op branch from ef8dd1b to 7e5a40b Compare April 22, 2024 11:58
@kalmarek kalmarek merged commit d06251a into master Apr 23, 2024
12 checks passed
@kalmarek kalmarek deleted the mk/SchreierTransversal_op branch April 23, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant