Skip to content

Commit e24de0a

Browse files
committed
Remove unnecessary sleep between test runs
The introduction of `sleep` between test runs in `dashboard_spec.js` and `detector_list_spec.js` was initially implemented to handle timing issues. However, these tests were actually failing due to a recent URL change, as detailed in opensearch-project/opensearch-dashboards-functional-test#1257. With the root cause of the failures addressed, the delays introduced by `sleep` commands are now redundant and can potentially slow down the testing process without providing any benefit. This PR removes these unnecessary sleep intervals between test executions. **Testing Done:** - Confirmed that all remote Cypress tests pass without the sleep intervals. Signed-off-by: Kaituo Li <kaituo@amazon.com>
1 parent 0a748c7 commit e24de0a

File tree

1 file changed

+1
-19
lines changed

1 file changed

+1
-19
lines changed

.github/workflows/remote-integ-tests-workflow.yml

+1-19
Original file line numberDiff line numberDiff line change
@@ -139,27 +139,9 @@ jobs:
139139
echo "::set-output name=cypress_version::$(cat ./package.json | jq '.dependencies.cypress' | tr -d '"')"
140140
working-directory: opensearch-dashboards-functional-test
141141

142-
- name: Finding spec files and store to output
143-
id: finding-files
144-
run: |
145-
echo "::set-output name=FILELIST::$(find cypress/integration/plugins/anomaly-detection-dashboards-plugin -name '*.js' -print)"
146-
working-directory: opensearch-dashboards-functional-test
147-
148-
- name: Print spec files from output
149-
run: |
150-
IFS="," read -a myarray <<< ${{ steps.finding-files.outputs.FILELIST }}
151-
for i in "${myarray[@]}"; do
152-
echo "${i}"
153-
done
154-
working-directory: opensearch-dashboards-functional-test
155-
156142
- name: Run spec files from output
157143
run: |
158-
IFS="," read -a myarray <<< ${{ steps.finding-files.outputs.FILELIST }}
159-
for i in "${myarray[@]}"; do
160-
yarn cypress:run-without-security --browser electron --spec "${i}"
161-
sleep 60
162-
done
144+
yarn cypress:run-without-security --browser electron --spec cypress/integration/plugins/anomaly-detection-dashboards-plugin/**/*.js
163145
working-directory: opensearch-dashboards-functional-test
164146

165147
- name: Capture failure screenshots

0 commit comments

Comments
 (0)